From: Daniel Lezcano <daniel.lezcano@linexp.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, khilman@baylibre.com,
abailon@baylibre.com, lukasz.luba@arm.com, broonie@kernel.org,
damien.lemoal@opensource.wdc.com, heiko@sntech.de,
hayashi.kunihiko@socionext.com, mhiramat@kernel.org,
talel@amazon.com, thierry.reding@gmail.com, digetx@gmail.com,
jonathanh@nvidia.com, anarsoul@gmail.com, tiny.windzz@gmail.com,
baolin.wang7@gmail.com, f.fainelli@gmail.com,
bjorn.andersson@linaro.org, mcoquelin.stm32@gmail.com,
glaroque@baylibre.com, miquel.raynal@bootlin.com,
shawnguo@kernel.org, niklas.soderlund@ragnatech.se,
matthias.bgg@gmail.com, j-keerthy@ti.com,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Amit Kucheria <amitk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL
DRIVER),
linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG
S3C, S5P AND EXYNOS ARM ARCHITECTURES)
Subject: [PATCH v4 30/32] thermal/drivers/samsung: Switch to new of thermal API
Date: Mon, 1 Aug 2022 23:22:42 +0200 [thread overview]
Message-ID: <20220801212244.1124867-31-daniel.lezcano@linexp.org> (raw)
In-Reply-To: <20220801212244.1124867-1-daniel.lezcano@linexp.org>
The thermal OF code has a new API allowing to migrate the OF
initialization to a simpler approach. The ops are no longer device
tree specific and are the generic ones provided by the core code.
Convert the ops to the thermal_zone_device_ops format and use the new
API to register the thermal zone with these generic ops.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linexp.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/thermal/samsung/exynos_tmu.c | 24 ++++++++++--------------
1 file changed, 10 insertions(+), 14 deletions(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index f4ab4c5b4b62..5b1a8a1e193d 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -650,9 +650,9 @@ static void exynos7_tmu_control(struct platform_device *pdev, bool on)
writel(con, data->base + EXYNOS_TMU_REG_CONTROL);
}
-static int exynos_get_temp(void *p, int *temp)
+static int exynos_get_temp(struct thermal_zone_device *tz, int *temp)
{
- struct exynos_tmu_data *data = p;
+ struct exynos_tmu_data *data = tz->devdata;
int value, ret = 0;
if (!data || !data->tmu_read)
@@ -728,9 +728,9 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data,
writel(val, data->base + emul_con);
}
-static int exynos_tmu_set_emulation(void *drv_data, int temp)
+static int exynos_tmu_set_emulation(struct thermal_zone_device *tz, int temp)
{
- struct exynos_tmu_data *data = drv_data;
+ struct exynos_tmu_data *data = tz->devdata;
int ret = -EINVAL;
if (data->soc == SOC_ARCH_EXYNOS4210)
@@ -750,7 +750,7 @@ static int exynos_tmu_set_emulation(void *drv_data, int temp)
}
#else
#define exynos4412_tmu_set_emulation NULL
-static int exynos_tmu_set_emulation(void *drv_data, int temp)
+static int exynos_tmu_set_emulation(struct thermal_zone *tz, int temp)
{ return -EINVAL; }
#endif /* CONFIG_THERMAL_EMULATION */
@@ -997,7 +997,7 @@ static int exynos_map_dt_data(struct platform_device *pdev)
return 0;
}
-static const struct thermal_zone_of_device_ops exynos_sensor_ops = {
+static const struct thermal_zone_device_ops exynos_sensor_ops = {
.get_temp = exynos_get_temp,
.set_emul_temp = exynos_tmu_set_emulation,
};
@@ -1091,8 +1091,8 @@ static int exynos_tmu_probe(struct platform_device *pdev)
* data->tzd must be registered before calling exynos_tmu_initialize(),
* requesting irq and calling exynos_tmu_control().
*/
- data->tzd = thermal_zone_of_sensor_register(&pdev->dev, 0, data,
- &exynos_sensor_ops);
+ data->tzd = devm_thermal_of_zone_register(&pdev->dev, 0, data,
+ &exynos_sensor_ops);
if (IS_ERR(data->tzd)) {
ret = PTR_ERR(data->tzd);
if (ret != -EPROBE_DEFER)
@@ -1104,21 +1104,19 @@ static int exynos_tmu_probe(struct platform_device *pdev)
ret = exynos_tmu_initialize(pdev);
if (ret) {
dev_err(&pdev->dev, "Failed to initialize TMU\n");
- goto err_thermal;
+ goto err_sclk;
}
ret = devm_request_irq(&pdev->dev, data->irq, exynos_tmu_irq,
IRQF_TRIGGER_RISING | IRQF_SHARED, dev_name(&pdev->dev), data);
if (ret) {
dev_err(&pdev->dev, "Failed to request irq: %d\n", data->irq);
- goto err_thermal;
+ goto err_sclk;
}
exynos_tmu_control(pdev, true);
return 0;
-err_thermal:
- thermal_zone_of_sensor_unregister(&pdev->dev, data->tzd);
err_sclk:
clk_disable_unprepare(data->sclk);
err_clk:
@@ -1136,9 +1134,7 @@ static int exynos_tmu_probe(struct platform_device *pdev)
static int exynos_tmu_remove(struct platform_device *pdev)
{
struct exynos_tmu_data *data = platform_get_drvdata(pdev);
- struct thermal_zone_device *tzd = data->tzd;
- thermal_zone_of_sensor_unregister(&pdev->dev, tzd);
exynos_tmu_control(pdev, false);
clk_disable_unprepare(data->sclk);
--
2.25.1
next prev parent reply other threads:[~2022-08-01 21:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 21:22 [PATCH v4] New thermal OF code Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 01/32] thermal/of: Rework the thermal device tree initialization Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 02/32] thermal/of: Make new code and old code co-exist Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 03/32] thermal/drivers/rockchip: Switch to new of API Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 04/32] thermal/drivers/uniphier: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 05/32] thermal/drivers/generic-adc: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 06/32] thermal/drivers/mmio: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 07/32] thermal/drivers/tegra: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 08/32] thermal/drivers/sun8i: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 09/32] thermal/drivers/sprd: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 10/32] thermal/drivers/broadcom: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 11/32] thermal/drivers/qcom: " Daniel Lezcano
2022-08-02 7:17 ` Dmitry Baryshkov
2022-08-01 21:22 ` [PATCH v4 12/32] thermal/drivers/st: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 13/32] thermal/drivers/amlogic: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 14/32] thermal/drivers/armada: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 15/32] thermal/drivers/db8500: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 16/32] thermal/drivers/imx: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 17/32] thermal/drivers/rcar: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 18/32] thermal/drivers/rzg2l: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 19/32] thermal/drivers/qoriq: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 20/32] thermal/drivers/mtk: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 21/32] thermal/drivers/banggap: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 22/32] thermal/drivers/maxim: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 23/32] thermal/drivers/hisilicon: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 24/32] thermal/drivers/ti-soc: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 25/32] ata/drivers/ahci_imx: Switch to new of thermal API Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 26/32] hwmon/drivers: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 27/32] iio/drivers/sun4i_gpadc: " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 28/32] Input: sun4i-ts - switch " Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 29/32] regulator/drivers/max8976: Switch " Daniel Lezcano
2022-08-01 21:22 ` Daniel Lezcano [this message]
2022-08-01 21:22 ` [PATCH v4 31/32] thermal/core: Move set_trip_temp ops to the sysfs code Daniel Lezcano
2022-08-01 21:22 ` [PATCH v4 32/32] thermal/of: Remove old OF code Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220801212244.1124867-31-daniel.lezcano@linexp.org \
--to=daniel.lezcano@linexp.org \
--cc=abailon@baylibre.com \
--cc=alim.akhtar@samsung.com \
--cc=amitk@kernel.org \
--cc=anarsoul@gmail.com \
--cc=baolin.wang7@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=bzolnier@gmail.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=digetx@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=glaroque@baylibre.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=heiko@sntech.de \
--cc=j-keerthy@ti.com \
--cc=jonathanh@nvidia.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mhiramat@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=niklas.soderlund@ragnatech.se \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
--cc=talel@amazon.com \
--cc=thierry.reding@gmail.com \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).