From: Rob Herring <robh@kernel.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Amit Kucheria <amitk@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
dan.carpenter@oracle.com, linux@roeck-us.net,
linux-pm@vger.kernel.org, rafael@kernel.org, michael@walle.cc,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] dt-bindings: thermal: Fix missing required property
Date: Tue, 9 Aug 2022 14:27:39 -0600 [thread overview]
Message-ID: <20220809202739.GA2338957-robh@kernel.org> (raw)
In-Reply-To: <20220809085629.509116-3-daniel.lezcano@linaro.org>
On Tue, 09 Aug 2022 10:56:28 +0200, Daniel Lezcano wrote:
> When the thermal zone description was converted to yaml schema, the
> required 'trips' property was forgotten.
>
> The initial text bindings was describing:
>
> "
> [ ... ]
>
> * Thermal zone nodes
>
> The thermal zone node is the node containing all the required info
> for describing a thermal zone, including its cooling device bindings. The
> thermal zone node must contain, apart from its own properties, one sub-node
> containing trip nodes and one sub-node containing all the zone cooling maps.
>
> Required properties:
> - polling-delay: The maximum number of milliseconds to wait between polls
> Type: unsigned when checking this thermal zone.
> Size: one cell
>
> - polling-delay-passive: The maximum number of milliseconds to wait
> Type: unsigned between polls when performing passive cooling.
> Size: one cell
>
> - thermal-sensors: A list of thermal sensor phandles and sensor specifier
> Type: list of used while monitoring the thermal zone.
> phandles + sensor
> specifier
>
> - trips: A sub-node which is a container of only trip point nodes
> Type: sub-node required to describe the thermal zone.
>
> Optional property:
> - cooling-maps: A sub-node which is a container of only cooling device
> Type: sub-node map nodes, used to describe the relation between trips
> and cooling devices.
> [ ... ]
>
> "
>
> Now the schema describes:
>
> "
> [ ... ]
>
> required:
> - polling-delay
> - polling-delay-passive
> - thermal-sensors
>
> [ ... ]
> "
>
> Add the missing 'trips' property in the required properties.
>
> Fixed: 1202a442a31fd ("dt-bindings: thermal: Add yaml bindings for thermal zones")
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> Documentation/devicetree/bindings/thermal/thermal-zones.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-08-09 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 8:56 [PATCH v2 1/4] thermal/of: Fix error code in of_thermal_zone_find() Daniel Lezcano
2022-08-09 8:56 ` [PATCH v2 2/4] thermal/of: Return -ENODEV instead of -EINVAL if registration fails Daniel Lezcano
2022-08-09 14:25 ` Guenter Roeck
2022-08-23 12:43 ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
2022-08-09 8:56 ` [PATCH v2 3/4] dt-bindings: thermal: Fix missing required property Daniel Lezcano
2022-08-09 20:27 ` Rob Herring [this message]
2022-08-15 18:43 ` [thermal: thermal/fixes] " thermal-bot for Daniel Lezcano
2022-08-09 8:56 ` [PATCH v2 4/4] thermal/of: Fix free after use in thermal_of_unregister() Daniel Lezcano
2022-08-09 14:26 ` Guenter Roeck
2022-08-23 12:43 ` [thermal: thermal/next] " thermal-bot for Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809202739.GA2338957-robh@kernel.org \
--to=robh@kernel.org \
--cc=amitk@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michael@walle.cc \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).