From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Amit Kucheria <amitk@kernel.org>
Subject: [PATCH v2 13/26] thermal/drivers/armada: Use generic thermal_zone_get_trip() function
Date: Wed, 10 Aug 2022 00:04:23 +0200 [thread overview]
Message-ID: <20220809220436.711020-14-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20220809220436.711020-1-daniel.lezcano@linaro.org>
The thermal framework gives the possibility to register the trip
points with the thermal zone. When that is done, no get_trip_* ops are
needed and they can be removed.
Convert ops content logic into generic trip points and register them with the
thermal zone.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/armada_thermal.c | 39 ++++++++++++++++----------------
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index 52d63b3997fe..9444e5a22ca0 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c
@@ -785,33 +785,34 @@ static int armada_configure_overheat_int(struct armada_thermal_priv *priv,
int sensor_id)
{
/* Retrieve the critical trip point to enable the overheat interrupt */
- const struct thermal_trip *trips = of_thermal_get_trip_points(tz);
+ struct thermal_trip trip;
int ret;
int i;
- if (!trips)
- return -EINVAL;
-
- for (i = 0; i < of_thermal_get_ntrips(tz); i++)
- if (trips[i].type == THERMAL_TRIP_CRITICAL)
- break;
+ for (i = 0; i < thermal_zone_get_num_trips(tz); i++) {
- if (i == of_thermal_get_ntrips(tz))
- return -EINVAL;
+ ret = thermal_zone_get_trip(tz, i, &trip);
+ if (ret)
+ return ret;
+
+ if (trip.type != THERMAL_TRIP_CRITICAL)
+ continue;
- ret = armada_select_channel(priv, sensor_id);
- if (ret)
- return ret;
+ ret = armada_select_channel(priv, sensor_id);
+ if (ret)
+ return ret;
+
+ armada_set_overheat_thresholds(priv, trip.temperature,
+ trip.hysteresis);
+ priv->overheat_sensor = tz;
+ priv->interrupt_source = sensor_id;
- armada_set_overheat_thresholds(priv,
- trips[i].temperature,
- trips[i].hysteresis);
- priv->overheat_sensor = tz;
- priv->interrupt_source = sensor_id;
+ armada_enable_overheat_interrupt(priv);
- armada_enable_overheat_interrupt(priv);
+ return 0;
+ }
- return 0;
+ return -EINVAL;
}
static int armada_thermal_probe(struct platform_device *pdev)
--
2.34.1
next prev parent reply other threads:[~2022-08-09 22:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 22:04 [PATCH v2 00/26] Rework the trip points creation Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 01/26] thermal/core: encapsulate ops->get_trip_* ops into a function Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 02/26] thermal/sysfs: Do not make get_trip_hyst optional Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 03/26] thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 04/26] thermal/drivers/st: Use generic trip points Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 05/26] thermal/drivers/tegra: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 06/26] thermal/drivers/imx: " Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 07/26] thermal/drivers/exynos: " Daniel Lezcano
2022-08-12 10:01 ` Krzysztof Kozlowski
2022-08-09 22:04 ` [PATCH v2 08/26] thermal/drivers/rcar: " Daniel Lezcano
2022-08-16 9:00 ` Niklas Söderlund
2022-08-09 22:04 ` [PATCH v2 09/26] thermal/drivers/uniphier: " Daniel Lezcano
2022-08-15 14:19 ` Kunihiko Hayashi
2022-08-09 22:04 ` [PATCH v2 10/26] thermal/drivers/hisi: " Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 11/26] thermal/drivers/qcom: " Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 12/26] thermal/drivers/OF: " Daniel Lezcano
2022-08-09 22:04 ` Daniel Lezcano [this message]
2022-08-09 22:04 ` [PATCH v2 14/26] thermal/core/OF: Remove unused functions Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 15/26] thermal/drivers/rcar_gen3: Use the generic function to get the number of trips Daniel Lezcano
2022-08-16 9:01 ` Niklas Söderlund
2022-08-09 22:04 ` [PATCH v2 16/26] thermal/drivers/exynos: of_thermal_get_ntrips() Daniel Lezcano
2022-08-12 10:02 ` Krzysztof Kozlowski
2022-08-09 22:04 ` [PATCH v2 17/26] thermal/core/of: Remove of_thermal_get_ntrips() Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 18/26] thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by thermal_zone_get_trip() Daniel Lezcano
2022-08-12 10:02 ` Krzysztof Kozlowski
2022-08-09 22:04 ` [PATCH v2 19/26] thermal/core/of: Remove of_thermal_is_trip_valid() Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 20/26] thermal/drivers/broadcom: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 21/26] thermal/drivers/da9062: " Daniel Lezcano
2022-08-10 8:57 ` DLG Adam Ward
2022-08-09 22:04 ` [PATCH v2 22/26] thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() / ti_thermal_trip_is_valid() Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 23/26] thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 24/26] thermal/drivers/cxgb4: " Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 25/26] thermal/intel/int340x: Replace parameter to simplify Daniel Lezcano
2022-08-09 22:04 ` [PATCH v2 26/26] thermal/drivers/intel: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-12 17:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220809220436.711020-14-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox