From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11EC8ECAAD3 for ; Wed, 14 Sep 2022 15:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229436AbiINPap (ORCPT ); Wed, 14 Sep 2022 11:30:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbiINPao (ORCPT ); Wed, 14 Sep 2022 11:30:44 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BF3CA4455F; Wed, 14 Sep 2022 08:30:42 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E5D0D1576; Wed, 14 Sep 2022 08:30:48 -0700 (PDT) Received: from bogus (unknown [10.57.48.254]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ADBD73F73D; Wed, 14 Sep 2022 08:30:40 -0700 (PDT) Date: Wed, 14 Sep 2022 16:30:38 +0100 From: Sudeep Holla To: Geert Uytterhoeven , Peng Fan Cc: Ulf Hansson , "ben.dooks@codethink.co.uk" , Sudeep Holla , "rafael.j.wysocki@intel.com" , "dmitry.baryshkov@linaro.org" , "jonathanh@nvidia.com" , "npitre@baylibre.com" , "linux-pm@vger.kernel.org" , Aisheng Dong , Linux-Renesas , Dien Pham Subject: Re: Question: why call clk_prepare in pm_clk_acquire Message-ID: <20220914153038.inbch35g7ldsyzhx@bogus> References: <20220908173840.rqy335cdeg5a2ww5@bogus> <20220909154254.xy4jvj6ybpuynghc@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Sep 12, 2022 at 06:58:49PM +0100, Geert Uytterhoeven wrote: > Hi Sudeep, > > CC Dien Pham > > On Mon, Sep 12, 2022 at 6:49 PM Geert Uytterhoeven wrote: > > On Fri, Sep 9, 2022 at 4:51 PM Sudeep Holla wrote: > > > On Fri, Sep 09, 2022 at 01:12:03PM +0200, Ulf Hansson wrote: > > > > On Thu, 8 Sept 2022 at 19:38, Sudeep Holla wrote: > > > > > On Thu, Sep 08, 2022 at 04:37:13PM +0200, Ulf Hansson wrote: > > > > > > On Thu, 8 Sept 2022 at 09:33, Peng Fan wrote: > > > > > > > We are facing an issue clk_set_rate fail with commit a3b884cef873 ("firmware: > > > > > > > arm_scmi: Add clock management to the SCMI power domain") , > > > > > > > > > > > > Hmm, I wonder about the main reason behind that commit. Can we revert > > > > > > it or is there some platform/driver that is really relying on it? > > > > > > > > > > > > > > > > IIUC, at the time of the commit, it was needed on some Renesas platform. > > > > > Not sure if it is still used or not. > > > > > > > > Okay! Maybe Nico remembers more, as he authored the patch... > > > > > > > > > > May be, or even check with Renesas team who tested his patch. > > > > I'm not aware of Renesas platforms using SCMI... > > Upon closer look, Diep Pham did report a build issue in the SCMI code, so > perhaps Diep knows more... > Yes indeed, Diep Pham tested the original patch IIRC and also has reported few bugs in SCMI clock code which are fixed. Hence I know it is used by Renesas. Hi Peng, Absence of DTS changes indicate nothing. I am aware of couple of vendors who use SCMI on several platforms and do report issues regularly and help in review of the code. So DTS is not a good indicator of SCMI usage unfortunately. On reason could be that since it is a firmware, bootloaders can detect and update DTS, just my thought and may differ from the reality. -- Regards, Sudeep