From: kernel test robot <lkp@intel.com>
To: Yinbo Zhu <zhuyinbo@loongson.cn>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org,
zhanghongchen <zhanghongchen@loongson.cn>,
Yinbo Zhu <zhuyinbo@loongson.cn>
Subject: Re: [PATCH v2 3/3] thermal: loongson2: add thermal management support
Date: Wed, 21 Sep 2022 16:45:53 +0800 [thread overview]
Message-ID: <202209211644.16Ox1qeg-lkp@intel.com> (raw)
In-Reply-To: <20220921015605.17078-3-zhuyinbo@loongson.cn>
Hi Yinbo,
I love your patch! Perhaps something to improve:
[auto build test WARNING on rafael-pm/thermal]
[also build test WARNING on linus/master v6.0-rc6 next-20220920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yinbo-Zhu/MAINTAINERS-add-maintainer-for-thermal-driver-for-loongson2-SoCs/20220921-095737
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220921/202209211644.16Ox1qeg-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/c21dcaa77e2e7514efdb4c97c805b14c9a05ec35
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Yinbo-Zhu/MAINTAINERS-add-maintainer-for-thermal-driver-for-loongson2-SoCs/20220921-095737
git checkout c21dcaa77e2e7514efdb4c97c805b14c9a05ec35
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/thermal/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/thermal/loongson2_thermal.c:183:5: warning: no previous prototype for 'loongson2_thermal_remove' [-Wmissing-prototypes]
183 | int loongson2_thermal_remove(struct platform_device *pdev)
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/loongson2_thermal_remove +183 drivers/thermal/loongson2_thermal.c
182
> 183 int loongson2_thermal_remove(struct platform_device *pdev)
184 {
185 struct loongson2_thermal_data *data = platform_get_drvdata(pdev);
186 int reg_off = data->id * 2;
187
188 /* disable interrupt */
189 writew(0, data->regs + LOONGSON2_TSENSOR_CTRL_LO + reg_off);
190 writew(0, data->regs + LOONGSON2_TSENSOR_CTRL_HI + reg_off);
191
192 return 0;
193 }
194
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-09-21 8:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 1:56 [PATCH v2 1/3] MAINTAINERS: add maintainer for thermal driver for loongson2 SoCs Yinbo Zhu
2022-09-21 1:56 ` [PATCH v2 2/3] dt-bindings: thermal: Convert loongson2 to json-schema Yinbo Zhu
2022-09-21 6:59 ` Krzysztof Kozlowski
2022-09-21 7:05 ` Krzysztof Kozlowski
2022-09-21 9:22 ` 朱银波
2022-09-21 9:31 ` Krzysztof Kozlowski
2022-09-22 1:39 ` 朱银波
2022-09-22 6:25 ` Krzysztof Kozlowski
2022-09-24 17:42 ` Rob Herring
2022-09-26 4:00 ` Yinbo Zhu
2022-09-26 6:21 ` Krzysztof Kozlowski
2022-09-26 8:38 ` Yinbo Zhu
2022-09-27 6:39 ` Yinbo Zhu
2022-09-27 11:08 ` Yinbo Zhu
2022-09-21 1:56 ` [PATCH v2 3/3] thermal: loongson2: add thermal management support Yinbo Zhu
2022-09-21 8:45 ` kernel test robot [this message]
2022-09-21 2:06 ` [PATCH v2 1/3] MAINTAINERS: add maintainer for thermal driver for loongson2 SoCs Joe Perches
2022-09-26 9:02 ` Yinbo Zhu
2022-09-26 12:13 ` xxxxxx Yinbo Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209211644.16Ox1qeg-lkp@intel.com \
--to=lkp@intel.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=zhanghongchen@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox