Re: [PATCH v3 14/17] timer: Implement the hierarchical pull model

kernel test robot
2022-10-26T05:36:48Z

[-- Attachment #1: Type: text/plain, Size: 5736 bytes --]

Hi Anna-Maria,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/timers/core]
[also build test WARNING on powerpc/next tip/x86/core linus/master tj-wq/for-next v6.1-rc2]
[cannot apply to tip/timers/nohz next-20221025]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Anna-Maria-Behnsen/timer-Move-from-a-push-remote-at-enqueue-to-a-pull-at-expiry-model/20221025-220106
patch link: https://lore.kernel.org/r/20221025135850.51044-15-anna-maria%40linutronix.de
patch subject: [PATCH v3 14/17] timer: Implement the hierarchical pull model
config: x86_64-rhel-8.3-func (attached as .config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/b57766ae36b5e3dd11225f0259f9fd7d39a79e94
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Anna-Maria-Behnsen/timer-Move-from-a-push-remote-at-enqueue-to-a-pull-at-expiry-model/20221025-220106
git checkout b57766ae36b5e3dd11225f0259f9fd7d39a79e94
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash kernel/time/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

kernel/time/timer_migration.c: In function 'tmigr_cpu_deactivate':
kernel/time/timer_migration.c:633:21: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
633 | u64 ret = tmc->wakeup;
| ^~~
In file included from include/linux/bitmap.h:9,
from include/linux/cpumask.h:12,
from arch/x86/include/asm/cpumask.h:5,
from arch/x86/include/asm/msr.h:11,
from arch/x86/include/asm/processor.h:22,
from arch/x86/include/asm/cpufeature.h:5,
from arch/x86/include/asm/thread_info.h:53,
from include/linux/thread_info.h:60,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:56,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/slab.h:15,
from kernel/time/timer_migration.c:8:
kernel/time/timer_migration.c: In function 'tmigr_inactive_up':
>> include/linux/find.h:168:37: warning: array subscript 'long unsigned int[0]' is partly outside array bounds of 'union tmigr_state[1]' [-Warray-bounds]
168 | unsigned long val = *addr & GENMASK(size - 1, 0);
| ^~~~~
kernel/time/timer_migration.c:495:37: note: while referencing 'newstate'
495 | union tmigr_state curstate, newstate;
| ^~~~~~~~

vim +168 include/linux/find.h

c7f612cdf091de include/asm-generic/bitops/find.h Akinobu Mita 2006-03-26 154
b7ec62d7ee0f0b include/asm-generic/bitops/find.h Yury Norov 2021-08-14 155 #ifndef find_first_bit
708ff2a0097b02 include/asm-generic/bitops/find.h Akinobu Mita 2010-09-29 156 /**
708ff2a0097b02 include/asm-generic/bitops/find.h Akinobu Mita 2010-09-29 157 * find_first_bit - find the first set bit in a memory region
708ff2a0097b02 include/asm-generic/bitops/find.h Akinobu Mita 2010-09-29 158 * @addr: The address to start the search at
ec778edf97dcaa include/asm-generic/bitops/find.h Cody P Schafer 2013-11-12 159 * @size: The maximum number of bits to search
708ff2a0097b02 include/asm-generic/bitops/find.h Akinobu Mita 2010-09-29 160 *
708ff2a0097b02 include/asm-generic/bitops/find.h Akinobu Mita 2010-09-29 161 * Returns the bit number of the first set bit.
ec778edf97dcaa include/asm-generic/bitops/find.h Cody P Schafer 2013-11-12 162 * If no bits are set, returns @size.
708ff2a0097b02 include/asm-generic/bitops/find.h Akinobu Mita 2010-09-29 163 */
2cc7b6a44ac21d include/asm-generic/bitops/find.h Yury Norov 2021-05-06 164 static inline
2cc7b6a44ac21d include/asm-generic/bitops/find.h Yury Norov 2021-05-06 165 unsigned long find_first_bit(const unsigned long *addr, unsigned long size)
2cc7b6a44ac21d include/asm-generic/bitops/find.h Yury Norov 2021-05-06 166 {
2cc7b6a44ac21d include/asm-generic/bitops/find.h Yury Norov 2021-05-06 167 if (small_const_nbits(size)) {
2cc7b6a44ac21d include/asm-generic/bitops/find.h Yury Norov 2021-05-06 @168 unsigned long val = *addr & GENMASK(size - 1, 0);
2cc7b6a44ac21d include/asm-generic/bitops/find.h Yury Norov 2021-05-06 169
2cc7b6a44ac21d include/asm-generic/bitops/find.h Yury Norov 2021-05-06 170 return val ? __ffs(val) : size;
2cc7b6a44ac21d include/asm-generic/bitops/find.h Yury Norov 2021-05-06 171 }
2cc7b6a44ac21d include/asm-generic/bitops/find.h Yury Norov 2021-05-06 172
2cc7b6a44ac21d include/asm-generic/bitops/find.h Yury Norov 2021-05-06 173 return _find_first_bit(addr, size);
2cc7b6a44ac21d include/asm-generic/bitops/find.h Yury Norov 2021-05-06 174 }
b7ec62d7ee0f0b include/asm-generic/bitops/find.h Yury Norov 2021-08-14 175 #endif
708ff2a0097b02 include/asm-generic/bitops/find.h Akinobu Mita 2010-09-29 176

--
0-DAY CI Kernel Test Service
https://01.org/lkp

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 40517 bytes --]