RE: [PATCH v3 0/5] AMD Pstate driver Urgent Change

Yuan, Perry
2022-11-22T02:18:25Z

[-- Attachment #1: Type: text/plain, Size: 4492 bytes --]

[AMD Official Use Only - General]

Hi Rafael

> -----Original Message-----
> From: Rafael J. Wysocki <rafael@kernel.org>
> Sent: Tuesday, November 22, 2022 3:24 AM
> To: Yuan, Perry <Perry.Yuan@amd.com>
> Cc: rafael.j.wysocki@intel.com; Huang, Ray <Ray.Huang@amd.com>;
> viresh.kumar@linaro.org; Limonciello, Mario <Mario.Limonciello@amd.com>;
> Fontenot, Nathan <Nathan.Fontenot@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Sharma, Deepak
> <Deepak.Sharma@amd.com>; Huang, Shimmer <Shimmer.Huang@amd.com>;
> Meng, Li (Jassmine) <Li.Meng@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>; Karny, Wyes <Wyes.Karny@amd.com>; Shenoy,
> Gautham Ranjal <gautham.shenoy@amd.com>; Narayan, Ananth
> <Ananth.Narayan@amd.com>; linux-pm@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v3 0/5] AMD Pstate driver Urgent Change
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Thu, Nov 17, 2022 at 8:36 AM Perry Yuan <Perry.Yuan@amd.com> wrote:
> >
> > The patchset changed amd-pstate driver as built-in type to resolve the
> > driver loading sequence problem, otherwise the acpi-cpufreq driver
> > will be loaded as the default cpufreq scaling driver instead of amd-pstate.
> >
> > Some new kernel parameters are added to allow user to disable pstate
> > driver and load driver with passive mode which use governors to do the
> > frequency scaling control.
> >
> > * `amd_pstate=disabled` or no parameters will not load pstate driver.
> > * `amd_pstate=passive` will load pstate driver with passive mode.
> >
> > Set the `amd_pstate` driver disabled by default because of performance
> > degradation on a number of AMD ASICs in the passive mode driver,
> > especially the shared memory support processors.
> >
> > EPP support for the amd_pstate driver is under review. With EPP
> > support, the said performance issue is resolved. Once that gets
> > upstream, the `active` mode amd_pstate_epp driver may be enabled by
> default.
> >
> > Changes from v2:
> > * pick up Acked-by flag of Huang Rui
> > * fix typo in the cover letter
> >
> > Changes from v1:
> > * fix commit info in v1 patch PATCH 4/5
> > * pick up Reviewed-by flag of Gautham R. Shenoy
> > * pick up Tested-by flag of Wyes Karny
> >
> > v2:
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
> > .kernel.org%2Flkml%2F20221117071910.3347052-1-
> Perry.Yuan%40amd.com%2F&
> >
> amp;data=05%7C01%7CPerry.Yuan%40amd.com%7C03f823ca38cf46b1994f0
> 8dacbf5
> >
> f499%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63804655448
> 7752737%7
> >
> CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> TiI6Ik1
> >
> haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=L3At1qrtRjPH%2
> Bpve%2BpLC
> > b%2B%2BGektsGn4LH9RcNwYfhlU%3D&amp;reserved=0
> > v1:
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore
> > .kernel.org%2Flkml%2F20221117024955.3319484-1-
> Perry.Yuan%40amd.com%2F&
> >
> amp;data=05%7C01%7CPerry.Yuan%40amd.com%7C03f823ca38cf46b1994f0
> 8dacbf5
> >
> f499%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63804655448
> 7752737%7
> >
> CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJB
> TiI6Ik1
> >
> haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=N6MhiQEIWPLkv
> kbwzycrKbky
> > E34fmjDydQxr7FwJSMQ%3D&amp;reserved=0
> >
> > Perry Yuan (4):
> > cpufreq: amd-pstate: change amd-pstate driver to be built-in type
> > cpufreq: amd-pstate: add amd-pstate driver parameter for mode
> > selection
> > Documentation: amd-pstate: add driver working mode introduction
> > Documentation: add amd-pstate kernel command line options
> >
> > Wyes Karny (1):
> > cpufreq: amd-pstate: cpufreq: amd-pstate: reset MSR_AMD_PERF_CTL
> > register at init
> >
> > .../admin-guide/kernel-parameters.txt | 11 +++++
> > Documentation/admin-guide/pm/amd-pstate.rst | 30 +++++-------
> > drivers/cpufreq/Kconfig.x86 | 2 +-
> > drivers/cpufreq/amd-pstate.c | 49 +++++++++++++------
> > 4 files changed, 59 insertions(+), 33 deletions(-)
> >
> > --
>
> I have applied this series as 6.1-rc7 material.
>
> Please let me know if you'd rather want to defer it till 6.2-rc1.
>
> Thanks!

Cool!
Thank you help to pick up the patches as 6.1-rc7 material.

Perry.

[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 19711 bytes --]