From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Johan Hovold <johan@kernel.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] OPP: Disallow "opp-hz" property without a corresponding clk
Date: Thu, 24 Nov 2022 10:54:43 +0530 [thread overview]
Message-ID: <20221124052443.GA5119@thinkpad> (raw)
In-Reply-To: <20221124042304.pk3rh7nfkanhlgsm@vireshk-i7>
On Thu, Nov 24, 2022 at 09:53:04AM +0530, Viresh Kumar wrote:
> On 22-11-22, 18:56, Manivannan Sadhasivam wrote:
> > If there is no .set_rate() callback implemented by the clock provider, it won't
> > hurt, right?
>
> It shouldn't, I guess. Well, in that case, is the first patch even
> required ? Maybe we should keep it, this makes clear that we won't
> even call set_rate(), irrespective of the face that it is implemented
> or not.
>
I don't think that detail is required to be made explicit. If someone cares,
they can easlily find out by glancing through the OPP code.
So IMO, we don't need patch 1/2.
> Also, the clk provider may not be part of this file later on, for
> other SoC versions, and it is better in that case too.
>
We cannot predict what the HW guys will come up with ;) But as said above, I
don't think it is necessary to to make it explicit.
Thanks,
Mani
> --
> viresh
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2022-11-24 5:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 6:57 [PATCH 0/2] OPP: Disallow "opp-hz" property without a corresponding clk Viresh Kumar
2022-11-21 6:57 ` [PATCH 1/2] cpufreq: qcom-cpufreq-hw: Register config_clks helper Viresh Kumar
2022-11-21 6:57 ` [PATCH 2/2] OPP: Disallow "opp-hz" property without a corresponding clk Viresh Kumar
2022-11-21 7:22 ` Johan Hovold
2022-11-21 7:38 ` Viresh Kumar
2022-11-21 7:42 ` Johan Hovold
2022-11-21 8:30 ` Viresh Kumar
2022-11-22 13:26 ` Manivannan Sadhasivam
2022-11-24 4:23 ` Viresh Kumar
2022-11-24 5:24 ` Manivannan Sadhasivam [this message]
2022-11-21 7:44 ` Manivannan Sadhasivam
2022-11-21 7:39 ` Manivannan Sadhasivam
2023-01-25 4:21 ` Viresh Kumar
2023-02-16 6:47 ` Manivannan Sadhasivam
2023-10-11 5:48 ` Viresh Kumar
2023-11-15 6:32 ` Viresh Kumar
2023-11-15 7:55 ` Manivannan Sadhasivam
2023-11-15 8:43 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221124052443.GA5119@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=andersson@kernel.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).