From: Perry Yuan <perry.yuan@amd.com>
To: <rafael.j.wysocki@intel.com>, <Mario.Limonciello@amd.com>,
<ray.huang@amd.com>, <viresh.kumar@linaro.org>
Cc: <Deepak.Sharma@amd.com>, <Nathan.Fontenot@amd.com>,
<Alexander.Deucher@amd.com>, <Shimmer.Huang@amd.com>,
<Xiaojian.Du@amd.com>, <Li.Meng@amd.com>, <wyes.karny@amd.com>,
<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v8 08/13] cpufreq: amd-pstate: implement suspend and resume callbacks
Date: Mon, 19 Dec 2022 14:40:37 +0800 [thread overview]
Message-ID: <20221219064042.661122-9-perry.yuan@amd.com> (raw)
In-Reply-To: <20221219064042.661122-1-perry.yuan@amd.com>
From: Perry Yuan <Perry.Yuan@amd.com>
add suspend and resume support for the AMD processors by amd_pstate_epp
driver instance.
When the CPPC is suspended, EPP driver will set EPP profile to 'power'
profile and set max/min perf to lowest perf value.
When resume happens, it will restore the MSR registers with
previous cached value.
Reviewed-by: Mario Limonciello <Mario.Limonciello@amd.com>
Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
---
drivers/cpufreq/amd-pstate.c | 41 ++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index cb647f55a169..fc12d35bc7bd 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -1107,6 +1107,45 @@ static int amd_pstate_epp_verify_policy(struct cpufreq_policy_data *policy)
return 0;
}
+static int amd_pstate_epp_suspend(struct cpufreq_policy *policy)
+{
+ struct amd_cpudata *cpudata = all_cpu_data[policy->cpu];
+ int ret;
+
+ /* avoid suspending when EPP is not enabled */
+ if (cppc_state != AMD_PSTATE_ACTIVE)
+ return 0;
+
+ /* set this flag to avoid setting core offline*/
+ cpudata->suspended = true;
+
+ /* disable CPPC in lowlevel firmware */
+ ret = amd_pstate_enable(false);
+ if (ret)
+ pr_err("failed to suspend, return %d\n", ret);
+
+ return 0;
+}
+
+static int amd_pstate_epp_resume(struct cpufreq_policy *policy)
+{
+ struct amd_cpudata *cpudata = all_cpu_data[policy->cpu];
+
+ if (cpudata->suspended) {
+ mutex_lock(&amd_pstate_limits_lock);
+
+ /* enable amd pstate from suspend state*/
+ amd_pstate_epp_reenable(cpudata);
+
+ mutex_unlock(&amd_pstate_limits_lock);
+
+ cpudata->suspended = false;
+ }
+
+ return 0;
+}
+
+
static struct cpufreq_driver amd_pstate_driver = {
.flags = CPUFREQ_CONST_LOOPS | CPUFREQ_NEED_UPDATE_LIMITS,
.verify = amd_pstate_verify,
@@ -1129,6 +1168,8 @@ static struct cpufreq_driver amd_pstate_epp_driver = {
.update_limits = amd_pstate_epp_update_limits,
.offline = amd_pstate_epp_cpu_offline,
.online = amd_pstate_epp_cpu_online,
+ .suspend = amd_pstate_epp_suspend,
+ .resume = amd_pstate_epp_resume,
.name = "amd_pstate_epp",
.attr = amd_pstate_epp_attr,
};
--
2.34.1
next prev parent reply other threads:[~2022-12-19 6:43 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 6:40 [PATCH v8 00/13] Implement AMD Pstate EPP Driver Perry Yuan
2022-12-19 6:40 ` [PATCH v8 01/13] ACPI: CPPC: Add AMD pstate energy performance preference cppc control Perry Yuan
2022-12-19 21:09 ` Limonciello, Mario
2022-12-23 2:16 ` Huang Rui
2022-12-23 3:19 ` Yuan, Perry
2022-12-23 9:06 ` Huang Rui
2022-12-25 16:41 ` Yuan, Perry
2022-12-19 6:40 ` [PATCH v8 02/13] Documentation: amd-pstate: add EPP profiles introduction Perry Yuan
2022-12-19 22:37 ` Limonciello, Mario
2022-12-19 6:40 ` [PATCH v8 03/13] cpufreq: intel_pstate: use common macro definition for Energy Preference Performance(EPP) Perry Yuan
2022-12-20 2:53 ` Mario Limonciello
2022-12-23 3:10 ` Huang Rui
2022-12-23 3:12 ` Yuan, Perry
2022-12-19 6:40 ` [PATCH v8 04/13] cpufreq: amd-pstate: fix kernel hang issue while amd-pstate unregistering Perry Yuan
2022-12-19 22:55 ` Limonciello, Mario
2022-12-19 6:40 ` [PATCH v8 05/13] cpufreq: amd-pstate: optimize driver working mode selection in amd_pstate_param() Perry Yuan
2022-12-19 23:01 ` Limonciello, Mario
2022-12-23 4:23 ` Huang Rui
2022-12-23 9:45 ` Wyes Karny
2022-12-25 16:41 ` Yuan, Perry
2022-12-19 6:40 ` [PATCH v8 06/13] cpufreq: amd-pstate: implement Pstate EPP support for the AMD processors Perry Yuan
2022-12-20 3:09 ` Mario Limonciello
2022-12-23 7:43 ` Huang Rui
2022-12-23 7:52 ` Yuan, Perry
2022-12-19 6:40 ` [PATCH v8 07/13] cpufreq: amd-pstate: implement amd pstate cpu online and offline callback Perry Yuan
2022-12-23 8:11 ` Huang Rui
2022-12-19 6:40 ` Perry Yuan [this message]
2022-12-23 8:12 ` [PATCH v8 08/13] cpufreq: amd-pstate: implement suspend and resume callbacks Huang Rui
2022-12-19 6:40 ` [PATCH v8 09/13] cpufreq: amd-pstate: add driver working mode switch support Perry Yuan
2022-12-19 23:38 ` Limonciello, Mario
2022-12-23 8:56 ` Huang Rui
2022-12-25 16:41 ` Yuan, Perry
2022-12-19 6:40 ` [PATCH v8 10/13] Documentation: amd-pstate: add amd pstate driver mode introduction Perry Yuan
2022-12-19 23:28 ` Limonciello, Mario
2022-12-19 6:40 ` [PATCH v8 11/13] Documentation: introduce amd pstate active mode kernel command line options Perry Yuan
2022-12-19 23:29 ` Limonciello, Mario
2022-12-19 6:40 ` [PATCH v8 12/13] cpufreq: amd-pstate: convert sprintf with sysfs_emit() Perry Yuan
2022-12-19 23:31 ` Limonciello, Mario
2022-12-25 16:42 ` Yuan, Perry
2022-12-23 7:45 ` Huang Rui
2022-12-19 6:40 ` [PATCH v8 13/13] Documentation: amd-pstate: introduce new global sysfs attributes Perry Yuan
2022-12-19 22:35 ` Limonciello, Mario
2022-12-20 18:13 ` [PATCH v8 00/13] Implement AMD Pstate EPP Driver Tor Vic
2022-12-20 18:52 ` Tor Vic
2022-12-21 3:08 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219064042.661122-9-perry.yuan@amd.com \
--to=perry.yuan@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Shimmer.Huang@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
--cc=wyes.karny@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox