public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <andersson@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Georgi Djakov <djakov@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] interconnect: qcom: osm-l3: drop unuserd header inclusion
Date: Mon, 2 Jan 2023 21:33:53 -0600	[thread overview]
Message-ID: <20230103033353.u3gzssofbmxlmn7o@builder.lan> (raw)
In-Reply-To: <20230103031159.1060075-1-dmitry.baryshkov@linaro.org>

On Tue, Jan 03, 2023 at 05:11:59AM +0200, Dmitry Baryshkov wrote:
> The commit 4529992c9474 ("interconnect: qcom: osm-l3: Use
> platform-independent node ids") made osm-l3 driver use
> platform-independent IDs, removing the need to include platform headers.
> 
> Fixes: 4529992c9474 ("interconnect: qcom: osm-l3: Use platform-independent node ids")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  drivers/interconnect/qcom/osm-l3.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/interconnect/qcom/osm-l3.c b/drivers/interconnect/qcom/osm-l3.c
> index 5fa171087425..0c907765783e 100644
> --- a/drivers/interconnect/qcom/osm-l3.c
> +++ b/drivers/interconnect/qcom/osm-l3.c
> @@ -14,13 +14,6 @@
>  
>  #include <dt-bindings/interconnect/qcom,osm-l3.h>
>  
> -#include "sc7180.h"
> -#include "sc7280.h"
> -#include "sc8180x.h"
> -#include "sdm845.h"
> -#include "sm8150.h"
> -#include "sm8250.h"
> -

Thanks for cleaning this up Dmitry. The <platform>_MASTER_OSM_L3_APPS
and <platform>_SLAVE_OSM_L3 in these header files could also be removed,
if you would like.

Either way, you have my:

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

>  #define LUT_MAX_ENTRIES			40U
>  #define LUT_SRC				GENMASK(31, 30)
>  #define LUT_L_VAL			GENMASK(7, 0)
> -- 
> 2.39.0
> 

  reply	other threads:[~2023-01-03  3:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-03  3:11 [PATCH] interconnect: qcom: osm-l3: drop unuserd header inclusion Dmitry Baryshkov
2023-01-03  3:33 ` Bjorn Andersson [this message]
2023-01-03  4:57   ` Dmitry Baryshkov
2023-01-03 13:32 ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230103033353.u3gzssofbmxlmn7o@builder.lan \
    --to=andersson@kernel.org \
    --cc=agross@kernel.org \
    --cc=djakov@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox