* [PATCH] interconnect: qcom: osm-l3: drop unuserd header inclusion
@ 2023-01-03 3:11 Dmitry Baryshkov
2023-01-03 3:33 ` Bjorn Andersson
2023-01-03 13:32 ` Konrad Dybcio
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-01-03 3:11 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Georgi Djakov
Cc: linux-arm-msm, linux-pm
The commit 4529992c9474 ("interconnect: qcom: osm-l3: Use
platform-independent node ids") made osm-l3 driver use
platform-independent IDs, removing the need to include platform headers.
Fixes: 4529992c9474 ("interconnect: qcom: osm-l3: Use platform-independent node ids")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/interconnect/qcom/osm-l3.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/interconnect/qcom/osm-l3.c b/drivers/interconnect/qcom/osm-l3.c
index 5fa171087425..0c907765783e 100644
--- a/drivers/interconnect/qcom/osm-l3.c
+++ b/drivers/interconnect/qcom/osm-l3.c
@@ -14,13 +14,6 @@
#include <dt-bindings/interconnect/qcom,osm-l3.h>
-#include "sc7180.h"
-#include "sc7280.h"
-#include "sc8180x.h"
-#include "sdm845.h"
-#include "sm8150.h"
-#include "sm8250.h"
-
#define LUT_MAX_ENTRIES 40U
#define LUT_SRC GENMASK(31, 30)
#define LUT_L_VAL GENMASK(7, 0)
--
2.39.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] interconnect: qcom: osm-l3: drop unuserd header inclusion
2023-01-03 3:11 [PATCH] interconnect: qcom: osm-l3: drop unuserd header inclusion Dmitry Baryshkov
@ 2023-01-03 3:33 ` Bjorn Andersson
2023-01-03 4:57 ` Dmitry Baryshkov
2023-01-03 13:32 ` Konrad Dybcio
1 sibling, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2023-01-03 3:33 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Konrad Dybcio, Georgi Djakov, linux-arm-msm, linux-pm
On Tue, Jan 03, 2023 at 05:11:59AM +0200, Dmitry Baryshkov wrote:
> The commit 4529992c9474 ("interconnect: qcom: osm-l3: Use
> platform-independent node ids") made osm-l3 driver use
> platform-independent IDs, removing the need to include platform headers.
>
> Fixes: 4529992c9474 ("interconnect: qcom: osm-l3: Use platform-independent node ids")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/interconnect/qcom/osm-l3.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/osm-l3.c b/drivers/interconnect/qcom/osm-l3.c
> index 5fa171087425..0c907765783e 100644
> --- a/drivers/interconnect/qcom/osm-l3.c
> +++ b/drivers/interconnect/qcom/osm-l3.c
> @@ -14,13 +14,6 @@
>
> #include <dt-bindings/interconnect/qcom,osm-l3.h>
>
> -#include "sc7180.h"
> -#include "sc7280.h"
> -#include "sc8180x.h"
> -#include "sdm845.h"
> -#include "sm8150.h"
> -#include "sm8250.h"
> -
Thanks for cleaning this up Dmitry. The <platform>_MASTER_OSM_L3_APPS
and <platform>_SLAVE_OSM_L3 in these header files could also be removed,
if you would like.
Either way, you have my:
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
> #define LUT_MAX_ENTRIES 40U
> #define LUT_SRC GENMASK(31, 30)
> #define LUT_L_VAL GENMASK(7, 0)
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] interconnect: qcom: osm-l3: drop unuserd header inclusion
2023-01-03 3:33 ` Bjorn Andersson
@ 2023-01-03 4:57 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2023-01-03 4:57 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Konrad Dybcio, Georgi Djakov, linux-arm-msm, linux-pm
On 03/01/2023 05:33, Bjorn Andersson wrote:
> On Tue, Jan 03, 2023 at 05:11:59AM +0200, Dmitry Baryshkov wrote:
>> The commit 4529992c9474 ("interconnect: qcom: osm-l3: Use
>> platform-independent node ids") made osm-l3 driver use
>> platform-independent IDs, removing the need to include platform headers.
>>
>> Fixes: 4529992c9474 ("interconnect: qcom: osm-l3: Use platform-independent node ids")
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>> drivers/interconnect/qcom/osm-l3.c | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/drivers/interconnect/qcom/osm-l3.c b/drivers/interconnect/qcom/osm-l3.c
>> index 5fa171087425..0c907765783e 100644
>> --- a/drivers/interconnect/qcom/osm-l3.c
>> +++ b/drivers/interconnect/qcom/osm-l3.c
>> @@ -14,13 +14,6 @@
>>
>> #include <dt-bindings/interconnect/qcom,osm-l3.h>
>>
>> -#include "sc7180.h"
>> -#include "sc7280.h"
>> -#include "sc8180x.h"
>> -#include "sdm845.h"
>> -#include "sm8150.h"
>> -#include "sm8250.h"
>> -
>
> Thanks for cleaning this up Dmitry. The <platform>_MASTER_OSM_L3_APPS
> and <platform>_SLAVE_OSM_L3 in these header files could also be removed,
> if you would like.
Nice suggestion, thank you. I've send a separate patch.
>
> Either way, you have my:
>
> Reviewed-by: Bjorn Andersson <andersson@kernel.org>
>
> Regards,
> Bjorn
>
>> #define LUT_MAX_ENTRIES 40U
>> #define LUT_SRC GENMASK(31, 30)
>> #define LUT_L_VAL GENMASK(7, 0)
>> --
>> 2.39.0
>>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] interconnect: qcom: osm-l3: drop unuserd header inclusion
2023-01-03 3:11 [PATCH] interconnect: qcom: osm-l3: drop unuserd header inclusion Dmitry Baryshkov
2023-01-03 3:33 ` Bjorn Andersson
@ 2023-01-03 13:32 ` Konrad Dybcio
1 sibling, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-01-03 13:32 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Georgi Djakov
Cc: linux-arm-msm, linux-pm
Typo in the subject: unuserd/unused
On 3.01.2023 04:11, Dmitry Baryshkov wrote:
> The commit 4529992c9474 ("interconnect: qcom: osm-l3: Use
> platform-independent node ids") made osm-l3 driver use
> platform-independent IDs, removing the need to include platform headers.
>
> Fixes: 4529992c9474 ("interconnect: qcom: osm-l3: Use platform-independent node ids")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/interconnect/qcom/osm-l3.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/osm-l3.c b/drivers/interconnect/qcom/osm-l3.c
> index 5fa171087425..0c907765783e 100644
> --- a/drivers/interconnect/qcom/osm-l3.c
> +++ b/drivers/interconnect/qcom/osm-l3.c
> @@ -14,13 +14,6 @@
>
> #include <dt-bindings/interconnect/qcom,osm-l3.h>
>
> -#include "sc7180.h"
> -#include "sc7280.h"
> -#include "sc8180x.h"
> -#include "sdm845.h"
> -#include "sm8150.h"
> -#include "sm8250.h"
> -
> #define LUT_MAX_ENTRIES 40U
> #define LUT_SRC GENMASK(31, 30)
> #define LUT_L_VAL GENMASK(7, 0)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-03 13:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-03 3:11 [PATCH] interconnect: qcom: osm-l3: drop unuserd header inclusion Dmitry Baryshkov
2023-01-03 3:33 ` Bjorn Andersson
2023-01-03 4:57 ` Dmitry Baryshkov
2023-01-03 13:32 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox