* [PATCH] thermal: intel: pch: Add support for Wellsburg PCH
@ 2023-01-07 19:25 Tim Zimmermann
2023-01-20 16:40 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Tim Zimmermann @ 2023-01-07 19:25 UTC (permalink / raw)
To: Tushar Dave, Zhang Rui; +Cc: linux-pm, linux-kernel, Tim Zimmermann
This adds the PCI ID for the Wellsburg C610 series chipset PCH. The
driver can read the temperature from the Wellsburg PCH with only the PCI
ID added and no other modifications.
Signed-off-by: Tim Zimmermann <tim@linux4.de>
---
drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
index dabf11a687a1..9e27f430e034 100644
--- a/drivers/thermal/intel/intel_pch_thermal.c
+++ b/drivers/thermal/intel/intel_pch_thermal.c
@@ -29,6 +29,7 @@
#define PCH_THERMAL_DID_CNL_LP 0x02F9 /* CNL-LP PCH */
#define PCH_THERMAL_DID_CML_H 0X06F9 /* CML-H PCH */
#define PCH_THERMAL_DID_LWB 0xA1B1 /* Lewisburg PCH */
+#define PCH_THERMAL_DID_WBG 0x8D24 /* Wellsburg PCH */
/* Wildcat Point-LP PCH Thermal registers */
#define WPT_TEMP 0x0000 /* Temperature */
@@ -350,6 +351,7 @@ enum board_ids {
board_cnl,
board_cml,
board_lwb,
+ board_wbg,
};
static const struct board_info {
@@ -380,6 +382,10 @@ static const struct board_info {
.name = "pch_lewisburg",
.ops = &pch_dev_ops_wpt,
},
+ [board_wbg] = {
+ .name = "pch_wellsburg",
+ .ops = &pch_dev_ops_wpt,
+ },
};
static int intel_pch_thermal_probe(struct pci_dev *pdev,
@@ -495,6 +501,8 @@ static const struct pci_device_id intel_pch_thermal_id[] = {
.driver_data = board_cml, },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
.driver_data = board_lwb, },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_WBG),
+ .driver_data = board_wbg, },
{ 0, },
};
MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
--
2.39.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] thermal: intel: pch: Add support for Wellsburg PCH
2023-01-07 19:25 [PATCH] thermal: intel: pch: Add support for Wellsburg PCH Tim Zimmermann
@ 2023-01-20 16:40 ` Rafael J. Wysocki
2023-01-20 17:50 ` srinivas pandruvada
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2023-01-20 16:40 UTC (permalink / raw)
To: Tim Zimmermann, Zhang Rui, Srinivas Pandruvada
Cc: Tushar Dave, linux-pm, linux-kernel
On Sat, Jan 7, 2023 at 8:42 PM Tim Zimmermann <tim@linux4.de> wrote:
>
> This adds the PCI ID for the Wellsburg C610 series chipset PCH. The
> driver can read the temperature from the Wellsburg PCH with only the PCI
> ID added and no other modifications.
>
> Signed-off-by: Tim Zimmermann <tim@linux4.de>
Rui, Srinivas, any objections to this one?
> ---
> drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
> index dabf11a687a1..9e27f430e034 100644
> --- a/drivers/thermal/intel/intel_pch_thermal.c
> +++ b/drivers/thermal/intel/intel_pch_thermal.c
> @@ -29,6 +29,7 @@
> #define PCH_THERMAL_DID_CNL_LP 0x02F9 /* CNL-LP PCH */
> #define PCH_THERMAL_DID_CML_H 0X06F9 /* CML-H PCH */
> #define PCH_THERMAL_DID_LWB 0xA1B1 /* Lewisburg PCH */
> +#define PCH_THERMAL_DID_WBG 0x8D24 /* Wellsburg PCH */
>
> /* Wildcat Point-LP PCH Thermal registers */
> #define WPT_TEMP 0x0000 /* Temperature */
> @@ -350,6 +351,7 @@ enum board_ids {
> board_cnl,
> board_cml,
> board_lwb,
> + board_wbg,
> };
>
> static const struct board_info {
> @@ -380,6 +382,10 @@ static const struct board_info {
> .name = "pch_lewisburg",
> .ops = &pch_dev_ops_wpt,
> },
> + [board_wbg] = {
> + .name = "pch_wellsburg",
> + .ops = &pch_dev_ops_wpt,
> + },
> };
>
> static int intel_pch_thermal_probe(struct pci_dev *pdev,
> @@ -495,6 +501,8 @@ static const struct pci_device_id intel_pch_thermal_id[] = {
> .driver_data = board_cml, },
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
> .driver_data = board_lwb, },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_WBG),
> + .driver_data = board_wbg, },
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] thermal: intel: pch: Add support for Wellsburg PCH
2023-01-20 16:40 ` Rafael J. Wysocki
@ 2023-01-20 17:50 ` srinivas pandruvada
2023-01-21 5:01 ` Zhang, Rui
0 siblings, 1 reply; 5+ messages in thread
From: srinivas pandruvada @ 2023-01-20 17:50 UTC (permalink / raw)
To: Rafael J. Wysocki, Tim Zimmermann, Zhang Rui
Cc: Tushar Dave, linux-pm, linux-kernel
On Fri, 2023-01-20 at 17:40 +0100, Rafael J. Wysocki wrote:
> On Sat, Jan 7, 2023 at 8:42 PM Tim Zimmermann <tim@linux4.de> wrote:
> >
> > This adds the PCI ID for the Wellsburg C610 series chipset PCH. The
> > driver can read the temperature from the Wellsburg PCH with only
> > the PCI
> > ID added and no other modifications.
> >
> > Signed-off-by: Tim Zimmermann <tim@linux4.de>
>
> Rui, Srinivas, any objections to this one?
No objection.
Thanks,
Srinivas
>
> > ---
> > drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/thermal/intel/intel_pch_thermal.c
> > b/drivers/thermal/intel/intel_pch_thermal.c
> > index dabf11a687a1..9e27f430e034 100644
> > --- a/drivers/thermal/intel/intel_pch_thermal.c
> > +++ b/drivers/thermal/intel/intel_pch_thermal.c
> > @@ -29,6 +29,7 @@
> > #define PCH_THERMAL_DID_CNL_LP 0x02F9 /* CNL-LP PCH */
> > #define PCH_THERMAL_DID_CML_H 0X06F9 /* CML-H PCH */
> > #define PCH_THERMAL_DID_LWB 0xA1B1 /* Lewisburg PCH */
> > +#define PCH_THERMAL_DID_WBG 0x8D24 /* Wellsburg PCH */
> >
> > /* Wildcat Point-LP PCH Thermal registers */
> > #define WPT_TEMP 0x0000 /* Temperature */
> > @@ -350,6 +351,7 @@ enum board_ids {
> > board_cnl,
> > board_cml,
> > board_lwb,
> > + board_wbg,
> > };
> >
> > static const struct board_info {
> > @@ -380,6 +382,10 @@ static const struct board_info {
> > .name = "pch_lewisburg",
> > .ops = &pch_dev_ops_wpt,
> > },
> > + [board_wbg] = {
> > + .name = "pch_wellsburg",
> > + .ops = &pch_dev_ops_wpt,
> > + },
> > };
> >
> > static int intel_pch_thermal_probe(struct pci_dev *pdev,
> > @@ -495,6 +501,8 @@ static const struct pci_device_id
> > intel_pch_thermal_id[] = {
> > .driver_data = board_cml, },
> > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
> > .driver_data = board_lwb, },
> > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_WBG),
> > + .driver_data = board_wbg, },
> > { 0, },
> > };
> > MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
> > --
> > 2.39.0
> >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] thermal: intel: pch: Add support for Wellsburg PCH
2023-01-20 17:50 ` srinivas pandruvada
@ 2023-01-21 5:01 ` Zhang, Rui
2023-01-24 14:47 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Zhang, Rui @ 2023-01-21 5:01 UTC (permalink / raw)
To: srinivas.pandruvada@linux.intel.com, rafael@kernel.org,
tim@linux4.de
Cc: tushar.n.dave@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
On Fri, 2023-01-20 at 09:50 -0800, srinivas pandruvada wrote:
> On Fri, 2023-01-20 at 17:40 +0100, Rafael J. Wysocki wrote:
> > On Sat, Jan 7, 2023 at 8:42 PM Tim Zimmermann <tim@linux4.de>
> > wrote:
> > > This adds the PCI ID for the Wellsburg C610 series chipset PCH.
> > > The
> > > driver can read the temperature from the Wellsburg PCH with only
> > > the PCI
> > > ID added and no other modifications.
> > >
> > > Signed-off-by: Tim Zimmermann <tim@linux4.de>
> >
> > Rui, Srinivas, any objections to this one?
> No objection.
>
And no objections from me.
thanks,
rui
> Thanks,
> Srinivas
>
> > > ---
> > > drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/drivers/thermal/intel/intel_pch_thermal.c
> > > b/drivers/thermal/intel/intel_pch_thermal.c
> > > index dabf11a687a1..9e27f430e034 100644
> > > --- a/drivers/thermal/intel/intel_pch_thermal.c
> > > +++ b/drivers/thermal/intel/intel_pch_thermal.c
> > > @@ -29,6 +29,7 @@
> > > #define PCH_THERMAL_DID_CNL_LP 0x02F9 /* CNL-LP PCH */
> > > #define PCH_THERMAL_DID_CML_H 0X06F9 /* CML-H PCH */
> > > #define PCH_THERMAL_DID_LWB 0xA1B1 /* Lewisburg PCH */
> > > +#define PCH_THERMAL_DID_WBG 0x8D24 /* Wellsburg PCH */
> > >
> > > /* Wildcat Point-LP PCH Thermal registers */
> > > #define WPT_TEMP 0x0000 /* Temperature */
> > > @@ -350,6 +351,7 @@ enum board_ids {
> > > board_cnl,
> > > board_cml,
> > > board_lwb,
> > > + board_wbg,
> > > };
> > >
> > > static const struct board_info {
> > > @@ -380,6 +382,10 @@ static const struct board_info {
> > > .name = "pch_lewisburg",
> > > .ops = &pch_dev_ops_wpt,
> > > },
> > > + [board_wbg] = {
> > > + .name = "pch_wellsburg",
> > > + .ops = &pch_dev_ops_wpt,
> > > + },
> > > };
> > >
> > > static int intel_pch_thermal_probe(struct pci_dev *pdev,
> > > @@ -495,6 +501,8 @@ static const struct pci_device_id
> > > intel_pch_thermal_id[] = {
> > > .driver_data = board_cml, },
> > > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_LWB),
> > > .driver_data = board_lwb, },
> > > + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_WBG),
> > > + .driver_data = board_wbg, },
> > > { 0, },
> > > };
> > > MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
> > > --
> > > 2.39.0
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] thermal: intel: pch: Add support for Wellsburg PCH
2023-01-21 5:01 ` Zhang, Rui
@ 2023-01-24 14:47 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2023-01-24 14:47 UTC (permalink / raw)
To: Zhang, Rui, srinivas.pandruvada@linux.intel.com, tim@linux4.de
Cc: rafael@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, tushar.n.dave@intel.com
On Sat, Jan 21, 2023 at 6:01 AM Zhang, Rui <rui.zhang@intel.com> wrote:
>
> On Fri, 2023-01-20 at 09:50 -0800, srinivas pandruvada wrote:
> > On Fri, 2023-01-20 at 17:40 +0100, Rafael J. Wysocki wrote:
> > > On Sat, Jan 7, 2023 at 8:42 PM Tim Zimmermann <tim@linux4.de>
> > > wrote:
> > > > This adds the PCI ID for the Wellsburg C610 series chipset PCH.
> > > > The
> > > > driver can read the temperature from the Wellsburg PCH with only
> > > > the PCI
> > > > ID added and no other modifications.
> > > >
> > > > Signed-off-by: Tim Zimmermann <tim@linux4.de>
> > >
> > > Rui, Srinivas, any objections to this one?
> > No objection.
> >
> And no objections from me.
OK
Applied as 6.3 material, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-24 14:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-07 19:25 [PATCH] thermal: intel: pch: Add support for Wellsburg PCH Tim Zimmermann
2023-01-20 16:40 ` Rafael J. Wysocki
2023-01-20 17:50 ` srinivas pandruvada
2023-01-21 5:01 ` Zhang, Rui
2023-01-24 14:47 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).