Re: [PATCH v3 6/8] arm64: dts: qcom: Add msm8939-pm8916.dtsi include

Konrad Dybcio
2023-01-18T14:09:58Z

On 17.01.2023 03:48, Bryan O'Donoghue wrote:
> From: Stephan Gerhold <stephan@gerhold.net>
>
> The msm8939-pm8916.dtsi include configures the regulator supplies of
> MSM8939 used together with PM8916, as recommended by Qualcomm. In rare
> cases where boards deviate from the recommended design they can just
> avoid using this include.
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi | 82 ++++++++++++++++++++
> 1 file changed, 82 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi
> new file mode 100644
> index 0000000000000..18a1b3cca01d6
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8939-pm8916.dtsi
> @@ -0,0 +1,82 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +#include "msm8939.dtsi"
> +#include "pm8916.dtsi"
> +
> +&dsi0 {
> + vdda-supply = <&pm8916_l2>;
> + vddio-supply = <&pm8916_l6>;
> +};
> +
> +&dsi1 {
> + vdda-supply = <&pm8916_l2>;
> + vddio-supply = <&pm8916_l6>;
> +};
> +
> +&dsi_phy0 {
> + vddio-supply = <&pm8916_l6>;
> +};
> +
> +&dsi_phy1 {
> + vddio-supply = <&pm8916_l6>;
> +};
> +
> +&mpss {
> + pll-supply = <&pm8916_l7>;
> +};
> +
> +&pronto {
> + vddpx-supply = <&pm8916_l7>;
> +
> + iris {
> + vddxo-supply = <&pm8916_l7>;
> + vddrfa-supply = <&pm8916_s3>;
> + vddpa-supply = <&pm8916_l9>;
> + vdddig-supply = <&pm8916_l5>;
> + };
> +};
> +
> +&sdhc_1 {
> + vmmc-supply = <&pm8916_l8>;
> + vqmmc-supply = <&pm8916_l5>;
> +};
> +
> +&sdhc_2 {
> + vmmc-supply = <&pm8916_l11>;
> + vqmmc-supply = <&pm8916_l12>;
> +};
> +
> +&usb_hs_phy {
> + v1p8-supply = <&pm8916_l7>;
> + v3p3-supply = <&pm8916_l13>;
> +};
> +
> +&rpm_requests {
> + smd_rpm_regulators: regulators {
> + compatible = "qcom,rpm-pm8916-regulators";
> +
> + /* pm8916_s1 is managed by rpmpd (MSM8939_VDDMDCX) */
> + /* pm8916_s2 is managed by rpmpd (MSM8939_VDDCX) */
> + pm8916_s3: s3 {};
> + pm8916_s4: s4 {};
> +
> + pm8916_l1: l1 {};
> + pm8916_l2: l2 {};
> + /* pm8916_l3 is managed by rpmpd (MSM8939_VDDMX) */
> + pm8916_l4: l4 {};
> + pm8916_l5: l5 {};
> + pm8916_l6: l6 {};
> + pm8916_l7: l7 {};
> + pm8916_l8: l8 {};
> + pm8916_l9: l9 {};
> + pm8916_l10: l10 {};
> + pm8916_l11: l11 {};
> + pm8916_l12: l12 {};
> + pm8916_l13: l13 {};
> + pm8916_l14: l14 {};
> + pm8916_l15: l15 {};
> + pm8916_l16: l16 {};
> + pm8916_l17: l17 {};
> + pm8916_l18: l18 {};
> + };
> +};