From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rafael@kernel.org, daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Mark Brown <broonie@kernel.org>, Amit Kucheria <amitk@kernel.org>,
Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH v4 01/19] thermal/core: Add a thermal zone 'devdata' accessor
Date: Tue, 28 Feb 2023 12:22:20 +0100 [thread overview]
Message-ID: <20230228112238.2312273-2-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20230228112238.2312273-1-daniel.lezcano@linaro.org>
The thermal zone device structure is exposed to the different drivers
and obviously they access the internals while that should be
restricted to the core thermal code.
In order to self-encapsulate the thermal core code, we need to prevent
the drivers accessing directly the thermal zone structure and provide
accessor functions to deal with.
Provide an accessor to the 'devdata' structure and make use of it in
the different drivers.
No functional changes intended.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Mark Brown <broonie@kernel.org>
---
drivers/thermal/thermal_core.c | 6 ++++++
include/linux/thermal.h | 7 +++++++
2 files changed, 13 insertions(+)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 0675df54c8e6..9fa12147fead 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1378,6 +1378,12 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type, int n
}
EXPORT_SYMBOL_GPL(thermal_zone_device_register);
+void *thermal_zone_device_priv(struct thermal_zone_device *tzd)
+{
+ return tzd->devdata;
+}
+EXPORT_SYMBOL_GPL(thermal_zone_device_priv);
+
/**
* thermal_zone_device_unregister - removes the registered thermal zone device
* @tz: the thermal zone device to remove
diff --git a/include/linux/thermal.h b/include/linux/thermal.h
index 2bb4bf33f4f3..7dbb5712434c 100644
--- a/include/linux/thermal.h
+++ b/include/linux/thermal.h
@@ -365,6 +365,8 @@ thermal_zone_device_register_with_trips(const char *, struct thermal_trip *, int
void *, struct thermal_zone_device_ops *,
struct thermal_zone_params *, int, int);
+void *thermal_zone_device_priv(struct thermal_zone_device *tzd);
+
int thermal_zone_bind_cooling_device(struct thermal_zone_device *, int,
struct thermal_cooling_device *,
unsigned long, unsigned long,
@@ -436,6 +438,11 @@ static inline int thermal_zone_get_offset(
struct thermal_zone_device *tz)
{ return -ENODEV; }
+static inline void *thermal_zone_device_priv(struct thermal_zone_device *tz)
+{
+ return NULL;
+}
+
static inline int thermal_zone_device_enable(struct thermal_zone_device *tz)
{ return -ENODEV; }
--
2.34.1
next prev parent reply other threads:[~2023-02-28 11:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 11:22 [PATCH v4 00/19] Self-encapsulate the thermal zone device structure Daniel Lezcano
2023-02-28 11:22 ` Daniel Lezcano [this message]
2023-02-28 11:22 ` [PATCH v4 02/19] thermal/core: Use the thermal zone 'devdata' accessor in thermal located drivers Daniel Lezcano
2023-03-01 16:20 ` Gole, Dhruva
2023-02-28 11:22 ` [PATCH v4 03/19] thermal/core: Use the thermal zone 'devdata' accessor in hwmon " Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 04/19] thermal/core: Use the thermal zone 'devdata' accessor in remaining drivers Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 05/19] thermal/core: Show a debug message when get_temp() fails Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 06/19] thermal: Remove debug or error messages in get_temp() ops Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 07/19] thermal/hwmon: Do not set no_hwmon before calling thermal_add_hwmon_sysfs() Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 08/19] thermal/hwmon: Use the right device for devm_thermal_add_hwmon_sysfs() Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 09/19] thermal: Don't use 'device' internal thermal zone structure field Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 10/19] thermal/core: Add thermal_zone_device structure 'type' accessor Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 11/19] thermal/drivers/spear: Don't use tz->device but pdev->dev Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 12/19] thermal: Add a thermal zone id accessor Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 13/19] thermal: Use thermal_zone_device_type() accessor Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 14/19] thermal/drivers/da9062: Don't access the thermal zone device fields Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 15/19] thermal/hwmon: Use the thermal_core.h header Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 16/19] thermal/drivers/tegra: Remove unneeded lock when setting a trip point Daniel Lezcano
2023-03-01 14:18 ` Thierry Reding
2023-03-01 14:35 ` Daniel Lezcano
2023-03-02 9:45 ` Thierry Reding
2023-03-02 10:11 ` Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 17/19] thermal/tegra: Do not enable the thermal zone, it is already enabled Daniel Lezcano
2023-03-01 14:29 ` Thierry Reding
2023-03-01 14:44 ` Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 18/19] thermal/drivers/acerhdf: Make interval setting only at module load time Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 19/19] thermal/drivers/acerhdf: Remove pointless governor test Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228112238.2312273-2-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox