From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rafael@kernel.org, daniel.lezcano@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
Mark Brown <broonie@kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org (open list:HARDWARE MONITORING)
Subject: [PATCH v4 03/19] thermal/core: Use the thermal zone 'devdata' accessor in hwmon located drivers
Date: Tue, 28 Feb 2023 12:22:22 +0100 [thread overview]
Message-ID: <20230228112238.2312273-4-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20230228112238.2312273-1-daniel.lezcano@linaro.org>
The thermal zone device structure is exposed to the different drivers
and obviously they access the internals while that should be
restricted to the core thermal code.
In order to self-encapsulate the thermal core code, we need to prevent
the drivers accessing directly the thermal zone structure and provide
accessor functions to deal with.
Use the devdata accessor introduced in the previous patch.
No functional changes intended.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Guenter Roeck <linux@roeck-us.net> #hwmon
Acked-by: Mark Brown <broonie@kernel.org>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/hwmon/hwmon.c | 4 ++--
drivers/hwmon/pmbus/pmbus_core.c | 2 +-
drivers/hwmon/scmi-hwmon.c | 2 +-
drivers/hwmon/scpi-hwmon.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
index 33edb5c02f7d..3adf5c3c75ed 100644
--- a/drivers/hwmon/hwmon.c
+++ b/drivers/hwmon/hwmon.c
@@ -154,7 +154,7 @@ static DEFINE_IDA(hwmon_ida);
#ifdef CONFIG_THERMAL_OF
static int hwmon_thermal_get_temp(struct thermal_zone_device *tz, int *temp)
{
- struct hwmon_thermal_data *tdata = tz->devdata;
+ struct hwmon_thermal_data *tdata = thermal_zone_device_priv(tz);
struct hwmon_device *hwdev = to_hwmon_device(tdata->dev);
int ret;
long t;
@@ -171,7 +171,7 @@ static int hwmon_thermal_get_temp(struct thermal_zone_device *tz, int *temp)
static int hwmon_thermal_set_trips(struct thermal_zone_device *tz, int low, int high)
{
- struct hwmon_thermal_data *tdata = tz->devdata;
+ struct hwmon_thermal_data *tdata = thermal_zone_device_priv(tz);
struct hwmon_device *hwdev = to_hwmon_device(tdata->dev);
const struct hwmon_chip_info *chip = hwdev->chip;
const struct hwmon_channel_info **info = chip->info;
diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index 95e95783972a..e39a327ac2a1 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -1272,7 +1272,7 @@ struct pmbus_thermal_data {
static int pmbus_thermal_get_temp(struct thermal_zone_device *tz, int *temp)
{
- struct pmbus_thermal_data *tdata = tz->devdata;
+ struct pmbus_thermal_data *tdata = thermal_zone_device_priv(tz);
struct pmbus_sensor *sensor = tdata->sensor;
struct pmbus_data *pmbus_data = tdata->pmbus_data;
struct i2c_client *client = to_i2c_client(pmbus_data->dev);
diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
index e192f0c67146..046ac157749d 100644
--- a/drivers/hwmon/scmi-hwmon.c
+++ b/drivers/hwmon/scmi-hwmon.c
@@ -141,7 +141,7 @@ static int scmi_hwmon_thermal_get_temp(struct thermal_zone_device *tz,
{
int ret;
long value;
- struct scmi_thermal_sensor *th_sensor = tz->devdata;
+ struct scmi_thermal_sensor *th_sensor = thermal_zone_device_priv(tz);
ret = scmi_hwmon_read_scaled_value(th_sensor->ph, th_sensor->info,
&value);
diff --git a/drivers/hwmon/scpi-hwmon.c b/drivers/hwmon/scpi-hwmon.c
index 4d75385f7d5e..121e5e9f487f 100644
--- a/drivers/hwmon/scpi-hwmon.c
+++ b/drivers/hwmon/scpi-hwmon.c
@@ -64,7 +64,7 @@ static void scpi_scale_reading(u64 *value, struct sensor_data *sensor)
static int scpi_read_temp(struct thermal_zone_device *tz, int *temp)
{
- struct scpi_thermal_zone *zone = tz->devdata;
+ struct scpi_thermal_zone *zone = thermal_zone_device_priv(tz);
struct scpi_sensors *scpi_sensors = zone->scpi_sensors;
struct scpi_ops *scpi_ops = scpi_sensors->scpi_ops;
struct sensor_data *sensor = &scpi_sensors->data[zone->sensor_id];
--
2.34.1
next prev parent reply other threads:[~2023-02-28 11:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 11:22 [PATCH v4 00/19] Self-encapsulate the thermal zone device structure Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 01/19] thermal/core: Add a thermal zone 'devdata' accessor Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 02/19] thermal/core: Use the thermal zone 'devdata' accessor in thermal located drivers Daniel Lezcano
2023-03-01 16:20 ` Gole, Dhruva
2023-02-28 11:22 ` Daniel Lezcano [this message]
2023-02-28 11:22 ` [PATCH v4 04/19] thermal/core: Use the thermal zone 'devdata' accessor in remaining drivers Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 05/19] thermal/core: Show a debug message when get_temp() fails Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 06/19] thermal: Remove debug or error messages in get_temp() ops Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 07/19] thermal/hwmon: Do not set no_hwmon before calling thermal_add_hwmon_sysfs() Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 08/19] thermal/hwmon: Use the right device for devm_thermal_add_hwmon_sysfs() Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 09/19] thermal: Don't use 'device' internal thermal zone structure field Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 10/19] thermal/core: Add thermal_zone_device structure 'type' accessor Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 11/19] thermal/drivers/spear: Don't use tz->device but pdev->dev Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 12/19] thermal: Add a thermal zone id accessor Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 13/19] thermal: Use thermal_zone_device_type() accessor Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 14/19] thermal/drivers/da9062: Don't access the thermal zone device fields Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 15/19] thermal/hwmon: Use the thermal_core.h header Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 16/19] thermal/drivers/tegra: Remove unneeded lock when setting a trip point Daniel Lezcano
2023-03-01 14:18 ` Thierry Reding
2023-03-01 14:35 ` Daniel Lezcano
2023-03-02 9:45 ` Thierry Reding
2023-03-02 10:11 ` Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 17/19] thermal/tegra: Do not enable the thermal zone, it is already enabled Daniel Lezcano
2023-03-01 14:29 ` Thierry Reding
2023-03-01 14:44 ` Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 18/19] thermal/drivers/acerhdf: Make interval setting only at module load time Daniel Lezcano
2023-02-28 11:22 ` [PATCH v4 19/19] thermal/drivers/acerhdf: Remove pointless governor test Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230228112238.2312273-4-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=broonie@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox