linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Yassine Oudjana <y.oudjana@protonmail.com>,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 0/2] interconnect: qcom: rpm: fix msm8996 interconnect registration
Date: Mon, 13 Mar 2023 09:49:51 +0100	[thread overview]
Message-ID: <20230313084953.24088-1-johan+linaro@kernel.org> (raw)

Christophe noticed that a recent patch adding a missing clock disable to
one of the Qualcomm rpm driver error paths was broken. This would lead
to the provider not being registered on msm8996 which is the only
platform using this code path.

Turns out, however, that the power domain attach during probe is bogus
and would always succeed as any power domain would already have been
attached by the platform bus code.

Georgi, the offending commit is currently in your icc-next (and local
icc-fixes) branch. Perhaps you can fold in the fixup unless you prefer
applying it on top.

The bogus PM domain lookup is redundant and confusing but should
otherwise be benign so the removal could be applied to either branch.

Johan


Johan Hovold (2):
  interconnect: qcom: rpm: fix msm8996 interconnect registration
  interconnect: qcom: rpm: drop bogus pm domain attach

 drivers/interconnect/qcom/icc-rpm.c | 5 -----
 drivers/interconnect/qcom/icc-rpm.h | 1 -
 drivers/interconnect/qcom/msm8996.c | 1 -
 3 files changed, 7 deletions(-)

-- 
2.39.2


             reply	other threads:[~2023-03-13  8:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13  8:49 Johan Hovold [this message]
2023-03-13  8:49 ` [PATCH 1/2] interconnect: qcom: rpm: fix msm8996 interconnect registration Johan Hovold
2023-03-13  8:57   ` Konrad Dybcio
2023-03-13  9:11     ` Johan Hovold
2023-03-13  8:49 ` [PATCH 2/2] interconnect: qcom: rpm: drop bogus pm domain attach Johan Hovold
2023-03-13  9:10   ` Konrad Dybcio
2023-03-13 19:58   ` Georgi Djakov
2023-03-14  7:46     ` Johan Hovold
2023-03-13 19:57 ` [PATCH 0/2] interconnect: qcom: rpm: fix msm8996 interconnect registration Georgi Djakov
2023-03-14  7:45   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230313084953.24088-1-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=djakov@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).