From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE2F4C6FD19 for ; Thu, 16 Mar 2023 12:43:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229543AbjCPMn2 (ORCPT ); Thu, 16 Mar 2023 08:43:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229799AbjCPMn1 (ORCPT ); Thu, 16 Mar 2023 08:43:27 -0400 Received: from relay05.th.seeweb.it (relay05.th.seeweb.it [IPv6:2001:4b7a:2000:18::166]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9413BAD3E for ; Thu, 16 Mar 2023 05:43:13 -0700 (PDT) Received: from SoMainline.org (D57D4C6E.static.ziggozakelijk.nl [213.125.76.110]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 62ABA40287; Thu, 16 Mar 2023 13:43:09 +0100 (CET) Date: Thu, 16 Mar 2023 13:43:07 +0100 From: Marijn Suijten To: Jonathan Cameron Cc: Rob Herring , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , iio@vger.kernel.org, Lars-Peter Clausen , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Manivannan Sadhasivam , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Dmitry Baryshkov , linux-pm@vger.kernel.org Subject: Re: [PATCH v3 2/3] dt-bindings: thermal: qcom-spmi-adc-tm5: Use generic ADC node name Message-ID: <20230316124307.pzuvbacsmjdootfx@SoMainline.org> References: <20230201204447.542385-1-marijn.suijten@somainline.org> <20230201204447.542385-3-marijn.suijten@somainline.org> <20230203212501.GA908601-robh@kernel.org> <20230205150645.549ff062@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230205150645.549ff062@jic23-huawei> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 2023-02-05 15:06:45, Jonathan Cameron wrote: > On Fri, 3 Feb 2023 15:25:01 -0600 > Rob Herring wrote: > > > On Wed, Feb 01, 2023 at 09:44:46PM +0100, Marijn Suijten wrote: > > > Update the example to reflect a future requirement for the generic > > > adc-chan node name on ADC channel nodes, while conveying the board name > > > of the channel in a label instead. > > > > I don't think we've defined 'adc-chan' as THE generic name. Looks like > > we have: > > > > adc-chan > > adc-channel > > channel > > > > 'channel' is the most common (except for QCom). > Good spot. > > We also have that defined as the channel name in > bindings/iio/adc.yaml Good point, let's match adc.yaml and use 'channel' instead. I'll respin this series with thas, as well as rebasing on -next to solve conflicts with 8013295662f5 ("arm64: dts: qcom: sc8280xp: Add label property to vadc channel nodes"): supposedly that DT originally relied on the `@XX` suffix bug :) > Now this particular binding doesn't use anything from that > generic binding (other than trivial use of reg) but better to be > consistent with it than not! Should it inherit the common binding, or was it omitted for a reason? - Marijn