From: Zhang Rui <rui.zhang@intel.com>
To: linux-pm@vger.kernel.org, rafael.j.wysocki@intel.com,
daniel.lezcano@linaro.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] thermal/core: update cooling device during thermal zone unregistration
Date: Tue, 21 Mar 2023 23:46:27 +0800 [thread overview]
Message-ID: <20230321154627.17787-1-rui.zhang@intel.com> (raw)
When unregistering a thermal zone device, update the cooling device in
case the cooling device is activated by the current thermal zone.
This fixes a problem that the frequency of ACPI processors are still
limited after unloading ACPI thermal driver while ACPI passive cooling
is activated.
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
drivers/thermal/thermal_core.c | 26 +++++++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index cfd4c1afeae7..9f120e3c9bf0 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1477,6 +1477,7 @@ void thermal_zone_device_unregister(struct thermal_zone_device *tz)
const struct thermal_zone_params *tzp;
struct thermal_cooling_device *cdev;
struct thermal_zone_device *pos = NULL;
+ struct thermal_instance *ti;
if (!tz)
return;
@@ -1497,9 +1498,22 @@ void thermal_zone_device_unregister(struct thermal_zone_device *tz)
/* Unbind all cdevs associated with 'this' thermal zone */
list_for_each_entry(cdev, &thermal_cdev_list, node) {
+ mutex_lock(&tz->lock);
+ list_for_each_entry(ti, &tz->thermal_instances, tz_node) {
+ if (ti->cdev == cdev)
+ break;
+ }
+
+ /* The cooling device is not used by current thermal zone */
+ if (ti->cdev != cdev) {
+ mutex_unlock(&tz->lock);
+ continue;
+ }
+ mutex_unlock(&tz->lock);
+
if (tz->ops->unbind) {
tz->ops->unbind(tz, cdev);
- continue;
+ goto deactivate_cdev;
}
if (!tzp || !tzp->tbp)
@@ -1511,6 +1525,16 @@ void thermal_zone_device_unregister(struct thermal_zone_device *tz)
tzp->tbp[i].cdev = NULL;
}
}
+
+deactivate_cdev:
+ /*
+ * The thermal instances for current thermal zone has been
+ * removed. Update the cooling device in case it is activated
+ * by current thermal zone device.
+ */
+ mutex_lock(&cdev->lock);
+ __thermal_cdev_update(cdev);
+ mutex_unlock(&cdev->lock);
}
mutex_unlock(&thermal_list_lock);
--
2.25.1
next reply other threads:[~2023-03-21 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 15:46 Zhang Rui [this message]
2023-03-21 19:43 ` [PATCH] thermal/core: update cooling device during thermal zone unregistration Rafael J. Wysocki
2023-03-22 6:00 ` Zhang, Rui
2023-03-22 8:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321154627.17787-1-rui.zhang@intel.com \
--to=rui.zhang@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox