From: Zhang Rui <rui.zhang@intel.com>
To: linux-pm@vger.kernel.org, rafael.j.wysocki@intel.com,
daniel.lezcano@linaro.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] thermal/core: Enforce paired .bind/.unbind callbacks
Date: Fri, 24 Mar 2023 15:08:06 +0800 [thread overview]
Message-ID: <20230324070807.6342-4-rui.zhang@intel.com> (raw)
In-Reply-To: <20230324070807.6342-1-rui.zhang@intel.com>
The .bind/.unbind callbacks are designed to allow the thermal zone
device to bind to/unbind from a matched cooling device, with thermal
instances created/deleted.
In this sense, .bind/.unbind callbacks must exist in pairs.
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
drivers/thermal/thermal_core.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 5225d65fb0e0..9c447f22cb39 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -1258,6 +1258,11 @@ thermal_zone_device_register_with_trips(const char *type, struct thermal_trip *t
if (num_trips > 0 && (!ops->get_trip_type || !ops->get_trip_temp) && !trips)
return ERR_PTR(-EINVAL);
+ if ((ops->bind && !ops->unbind) || (!ops->bind && ops->unbind)) {
+ pr_err("Thermal zone device .bind/.unbind not paired\n");
+ return ERR_PTR(-EINVAL);
+ }
+
if (!thermal_class)
return ERR_PTR(-ENODEV);
--
2.25.1
next prev parent reply other threads:[~2023-03-24 7:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 7:08 [PATCH v2 1/5] thermal/core: Update cooling device during thermal zone unregistration Zhang Rui
2023-03-24 7:08 ` [PATCH 2/5] thermal/core: Reset cooling state during cooling device unregistration Zhang Rui
2023-03-24 13:19 ` Rafael J. Wysocki
2023-03-27 14:50 ` Zhang, Rui
2023-03-27 15:13 ` Rafael J. Wysocki
2023-03-28 2:46 ` Zhang, Rui
2023-03-28 17:54 ` Rafael J. Wysocki
2023-03-29 6:28 ` Zhang, Rui
2023-03-24 7:08 ` [PATCH 3/5] thermal/core: Remove thermal_bind_params structure Zhang Rui
2023-03-29 18:39 ` Rafael J. Wysocki
2023-03-30 1:11 ` Zhang, Rui
2023-03-24 7:08 ` Zhang Rui [this message]
2023-03-24 13:24 ` [PATCH 4/5] thermal/core: Enforce paired .bind/.unbind callbacks Rafael J. Wysocki
2023-03-24 13:25 ` Rafael J. Wysocki
2023-03-27 15:03 ` Zhang, Rui
2023-03-24 7:08 ` [PATCH 5/5] thermal/core: Avoid unbind for thermal zones without .unbind() Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324070807.6342-4-rui.zhang@intel.com \
--to=rui.zhang@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).