linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yang Shi <yang@os.amperecomputing.com>
To: rafael@kernel.org, viresh.kumar@linaro.org
Cc: yang@os.amperecomputing.com, scott@os.amperecomputing.com,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] cpufreq: CPPC: use 10ms delay instead of 2us to avoid high error
Date: Tue, 28 Mar 2023 12:38:46 -0700	[thread overview]
Message-ID: <20230328193846.8757-1-yang@os.amperecomputing.com> (raw)

When testing CPPC cpufreq on our platform, we noticed the error may be quite
high and the high error may happen quite often.  For example, on a platform
with a maximum frequency of 2.8GHz when the CPUs were fully loaded (100% load),
we saw cpuinfo_cur_freq may show 4GHz, it means the error is > 40%.  And the
high error (> 1%) happened 256 times out of 2127 samples (sampled every 3
seconds) in an approximate 2hrs test.

We tried to enlarge the delay, and tested with 100us, 1ms and 10ms.  The
below is the results.

100us:
The highest error is 4GHz, 22 times out of 3623 samples

1ms:
The highest error is 3.3GHz, 3 times out of 2814 samples

10ms:
No high error anymore

Increase the measurement delay in cppc_cpufreq_get_rate to 10ms to avoid
high measurement errors.

Signed-off-by: Yang Shi <yang@os.amperecomputing.com>
---
 drivers/cpufreq/cppc_cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
index 022e3555407c..c2bf65448d3d 100644
--- a/drivers/cpufreq/cppc_cpufreq.c
+++ b/drivers/cpufreq/cppc_cpufreq.c
@@ -851,7 +851,7 @@ static unsigned int cppc_cpufreq_get_rate(unsigned int cpu)
 	if (ret)
 		return ret;
 
-	udelay(2); /* 2usec delay between sampling */
+	mdelay(10); /* 10msec delay between sampling */
 
 	ret = cppc_get_perf_ctrs(cpu, &fb_ctrs_t1);
 	if (ret)
-- 
2.39.2


             reply	other threads:[~2023-03-28 19:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 19:38 Yang Shi [this message]
2023-03-29 18:43 ` [PATCH] cpufreq: CPPC: use 10ms delay instead of 2us to avoid high error Rafael J. Wysocki
2023-03-29 23:22   ` Yang Shi
2023-04-04 19:07   ` Yang Shi
2023-04-05 17:57     ` Pierre Gondois
2023-04-06 21:52       ` Yang Shi
2023-04-07  8:31         ` Pierre Gondois
2023-04-07 22:19           ` Yang Shi
2023-04-11  8:51             ` Pierre Gondois
2023-04-18 18:24               ` Yang Shi
2023-04-19  9:45                 ` Pierre Gondois
2023-04-19 16:52                   ` Pierre Gondois
2023-04-19 20:40                   ` Yang Shi
2023-04-20 16:01                     ` Pierre Gondois
2023-04-20 20:49                       ` Yang Shi
2023-04-24 11:44                         ` Ionela Voinescu
2023-04-26  1:32                           ` Yang Shi
2023-04-26 19:01                             ` Ionela Voinescu
2023-04-27 20:40                               ` Yang Shi
2023-04-28 11:02                                 ` Sumit Gupta
2023-03-30  3:56 ` Viresh Kumar
2023-03-31  9:53   ` Pierre Gondois
2023-04-04 18:57     ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230328193846.8757-1-yang@os.amperecomputing.com \
    --to=yang@os.amperecomputing.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=scott@os.amperecomputing.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).