From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <amitk@kernel.org>,
<thara.gopinath@gmail.com>, <rafael@kernel.org>,
<daniel.lezcano@linaro.org>, <rui.zhang@intel.com>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Praveenkumar I <quic_ipkumar@quicinc.com>
Subject: Re: [PATCH 1/4] dt-bindings: thermal: tsens: Add ipq9574 compatible
Date: Wed, 3 May 2023 12:40:56 +0530 [thread overview]
Message-ID: <20230503071055.GB1087@varda-linux.qualcomm.com> (raw)
In-Reply-To: <16443d11-7948-d224-cfef-b6c1b5c3d60d@linaro.org>
On Mon, May 01, 2023 at 09:08:49AM +0200, Krzysztof Kozlowski wrote:
> On 28/04/2023 16:52, Varadarajan Narayanan wrote:
> > From: Praveenkumar I <quic_ipkumar@quicinc.com>
> >
> > Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens.
> >
> > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > ---
> > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > index d1ec963..8e2208c 100644
> > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> > @@ -66,6 +66,7 @@ properties:
> > - description: v2 of TSENS with combined interrupt
> > enum:
> > - qcom,ipq8074-tsens
> > + - qcom,ipq9574-tsens
>
> Your drive change indicates they are compatible, so make them
> compatible. 9574 followed by 8074.
Not able to understand. You want IPQ9574 to use "qcom,ipq8074-tsens"
instead of adding a "qcom,ipq9574-tsens" and no need to add an extra
entry to the driver like
}, {
.compatible = "qcom,ipq9574-tsens",
.data = &data_ipq8074,
}, {
Thanks
Varada
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-05-03 7:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 14:52 [PATCH 0/4] Enable IPQ9574 TSENS support Varadarajan Narayanan
2023-04-28 14:52 ` [PATCH 1/4] dt-bindings: thermal: tsens: Add ipq9574 compatible Varadarajan Narayanan
2023-05-01 7:08 ` Krzysztof Kozlowski
2023-05-03 7:10 ` Varadarajan Narayanan [this message]
2023-05-03 7:42 ` Krzysztof Kozlowski
2023-05-04 4:57 ` Varadarajan Narayanan
2023-05-04 6:22 ` Krzysztof Kozlowski
2023-05-05 10:18 ` Varadarajan Narayanan
2023-04-28 14:52 ` [PATCH 2/4] thermal/drivers/tsens: Add IPQ9574 support Varadarajan Narayanan
2023-04-28 14:52 ` [PATCH 3/4] arm64: dts: qcom: ipq9574: add tsens node Varadarajan Narayanan
2023-04-28 14:52 ` [PATCH 4/4] arm64: dts: qcom: ipq9574: add thermal zone nodes Varadarajan Narayanan
2023-04-28 19:49 ` Dmitry Baryshkov
2023-05-02 8:04 ` Varadarajan Narayanan
2023-05-02 8:39 ` Dmitry Baryshkov
2023-05-01 7:14 ` Krzysztof Kozlowski
2023-05-02 8:06 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230503071055.GB1087@varda-linux.qualcomm.com \
--to=quic_varada@quicinc.com \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_ipkumar@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).