From: Shawn Guo <shawn.guo@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Georgi Djakov <djakov@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Yassine Oudjana <y.oudjana@protonmail.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] interconnect: icc-clk: fix modular build
Date: Sun, 21 May 2023 11:02:32 +0800 [thread overview]
Message-ID: <20230521030232.GA539244@dragon> (raw)
In-Reply-To: <20230519230122.3958816-1-dmitry.baryshkov@linaro.org>
On Sat, May 20, 2023 at 02:01:22AM +0300, Dmitry Baryshkov wrote:
> Fix building interconnect-clk as a module:
> - Add EXPORT_SYMBOL_GPL to the exported functions
> - Add MODULE_DESCRIPTION/_LICENSE/_AUTHOR
>
> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/interconnect/icc-clk.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/interconnect/icc-clk.c b/drivers/interconnect/icc-clk.c
> index 0db3b654548b..4d43ebff4257 100644
> --- a/drivers/interconnect/icc-clk.c
> +++ b/drivers/interconnect/icc-clk.c
> @@ -146,6 +146,7 @@ struct icc_provider *icc_clk_register(struct device *dev,
>
> return ERR_PTR(ret);
> }
> +EXPORT_SYMBOL_GPL(icc_clk_register);
>
> /**
> * icc_clk_unregister() - unregister a previously registered clk interconnect provider
> @@ -166,3 +167,8 @@ void icc_clk_unregister(struct icc_provider *provider)
> clk_disable_unprepare(qn->clk);
> }
> }
> +EXPORT_SYMBOL_GPL(icc_clk_unregister);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Interconnect wrapper for clocks");
> +MODULE_AUTHOR("Dmitry Baryshkov <dmitry.baryshkov@linaro.org>");
> --
> 2.39.2
>
prev parent reply other threads:[~2023-05-21 3:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 23:01 [PATCH] interconnect: icc-clk: fix modular build Dmitry Baryshkov
2023-05-21 3:02 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230521030232.GA539244@dragon \
--to=shawn.guo@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).