From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08A0C77B75 for ; Tue, 23 May 2023 16:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbjEWQfL (ORCPT ); Tue, 23 May 2023 12:35:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236334AbjEWQfK (ORCPT ); Tue, 23 May 2023 12:35:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85FF6E78; Tue, 23 May 2023 09:34:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 19D3D62C22; Tue, 23 May 2023 16:34:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F164DC433EF; Tue, 23 May 2023 16:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684859682; bh=F/c4b6SDJLSjnmx0l1YhNCJYsfrfz7bbIyvWirnoONE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=y1F873iGV7qiSJp8jB27qP3VdL7p/Yqsp0nQoA6P2mOxMchv2Km77Ocgue5H4Z3Zd WUpNTp+FYIKLD5fXQlFDucQD/qm/1M3vAcmET6I5ccJJtPnphZ93T6vtddFyMWQ0H7 mxZ50MBpYuwHmtxHJ63pwMtKkfCh6UrlNJQpkJ04= Date: Tue, 23 May 2023 17:34:38 +0100 From: Greg Kroah-Hartman To: Christoph Hellwig Cc: Jens Axboe , "Rafael J. Wysocki" , Mike Snitzer , Joern Engel , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Pavel Machek , dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 01/24] driver core: return bool from driver_probe_done Message-ID: <2023052330-perpetual-baritone-f867@gregkh> References: <20230523074535.249802-1-hch@lst.de> <20230523074535.249802-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230523074535.249802-2-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, May 23, 2023 at 09:45:12AM +0200, Christoph Hellwig wrote: > bool is the most sensible return value for a yes/no return. Also > add __init as this funtion is only called from the early boot code. > > Signed-off-by: Christoph Hellwig > --- > drivers/base/dd.c | 6 ++---- > include/linux/device/driver.h | 2 +- > init/do_mounts.c | 2 +- > 3 files changed, 4 insertions(+), 6 deletions(-) Acked-by: Greg Kroah-Hartman