From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31C55C77B73 for ; Wed, 24 May 2023 06:08:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239633AbjEXGIu (ORCPT ); Wed, 24 May 2023 02:08:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235788AbjEXGIt (ORCPT ); Wed, 24 May 2023 02:08:49 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18447132; Tue, 23 May 2023 23:08:49 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4CF6E68CFE; Wed, 24 May 2023 08:08:45 +0200 (CEST) Date: Wed, 24 May 2023 08:08:44 +0200 From: Christoph Hellwig To: Randy Dunlap Cc: Christoph Hellwig , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Mike Snitzer , Joern Engel , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Pavel Machek , dm-devel@redhat.com, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 15/24] block: move the code to do early boot lookup of block devices to block/ Message-ID: <20230524060844.GC19611@lst.de> References: <20230523074535.249802-1-hch@lst.de> <20230523074535.249802-16-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, May 23, 2023 at 09:59:50PM -0700, Randy Dunlap wrote: > >> root= [KNL] Root filesystem > >> - See early_lookup_bdev comment in init/do_mounts.c. > >> + See early_lookup_bdev comment in block/early-lookup.c > > > > Patch 13 does this: > > > > root= [KNL] Root filesystem > > - See name_to_dev_t comment in init/do_mounts.c. > > + See early_lookup_bdev comment in init/do_mounts.c. > > > > Should this latter chunk be dropped? > > > > Oh, oops, reverse order of patches? Patch 13 renames the function, this patch moves it. So I think this correct, but feel free to double check my foggy brain :)