Re: [PATCH 08/31] block: share code between disk_check_media_change and disk_force_media_change

Christoph Hellwig
2023-06-07T12:21:47Z

On Wed, Jun 07, 2023 at 02:19:00PM +0200, Hannes Reinecke wrote:
>> - return true;
>> + return __disk_check_media_change(disk,
>> + disk_clear_events(disk, DISK_EVENT_MEDIA_CHANGE |
>> + DISK_EVENT_EJECT_REQUEST));
>
> Can you move the call to disk_clear_events() out of the call to
> __disk_check_media_change()?
> I find this pattern hard to read.

I suspect you've not done enough functional programming in your youth :)