From: Waiman Long <longman@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Len Brown <lenb@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
linux-pm@vger.kernel.org, Robin Jarry <rjarry@redhat.com>,
Joe Mario <jmario@redhat.com>, Waiman Long <longman@redhat.com>
Subject: [PATCH v2 1/5] x86/speculation: Provide a debugfs file to dump SPEC_CTRL MSRs
Date: Tue, 20 Jun 2023 10:06:21 -0400 [thread overview]
Message-ID: <20230620140625.1001886-2-longman@redhat.com> (raw)
In-Reply-To: <20230620140625.1001886-1-longman@redhat.com>
Sometimes it is useful to know the states the SPEC_CTRL MSRs to see what
mitigations are enabled at run time. Provide a new x86/spec_ctrl_msrs
debugfs file to dump the cached versions of the current SPEC_CTRL MSRs.
Signed-off-by: Waiman Long <longman@redhat.com>
---
arch/x86/kernel/cpu/bugs.c | 79 ++++++++++++++++++++++++++++++++++++++
1 file changed, 79 insertions(+)
diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c
index 182af64387d0..f6e5910a4a2d 100644
--- a/arch/x86/kernel/cpu/bugs.c
+++ b/arch/x86/kernel/cpu/bugs.c
@@ -17,6 +17,7 @@
#include <linux/sched/smt.h>
#include <linux/pgtable.h>
#include <linux/bpf.h>
+#include <linux/debugfs.h>
#include <asm/spec-ctrl.h>
#include <asm/cmdline.h>
@@ -1733,6 +1734,84 @@ void cpu_bugs_smt_update(void)
mutex_unlock(&spec_ctrl_mutex);
}
+#ifdef CONFIG_DEBUG_FS
+/*
+ * Provide a debugfs file to dump SPEC_CTRL MSRs of all the CPUs
+ * Consecutive MSR values are collapsed together if they are the same.
+ */
+static ssize_t spec_ctrl_msrs_read(struct file *file, char __user *user_buf,
+ size_t count, loff_t *ppos)
+{
+ int bufsiz = min(count, PAGE_SIZE);
+ int cpu, prev_cpu, len, cnt = 0;
+ u64 val, prev_val;
+ char *buf;
+
+ /*
+ * The MSRs info should be small enough that the whole buffer is
+ * copied out in one call. However, user space may read it again
+ * to see if there is any data left. Rereading the cached SPEC_CTRL
+ * MSR values may produce a different result causing corruption in
+ * output data. So skipping the call if *ppos is not starting from 0.
+ */
+ if (*ppos)
+ return 0;
+
+ buf = kmalloc(bufsiz, GFP_KERNEL);
+ if (!buf)
+ return -ENOMEM;
+
+ for_each_possible_cpu(cpu) {
+ val = per_cpu(x86_spec_ctrl_current, cpu);
+
+ if (!cpu)
+ goto next;
+
+ if (val == prev_val)
+ continue;
+
+ if (prev_cpu == cpu - 1)
+ len = snprintf(buf + cnt, bufsiz - cnt, "CPU %d: 0x%llx\n",
+ prev_cpu, prev_val);
+ else
+ len = snprintf(buf + cnt, bufsiz - cnt, "CPUs %d-%d: 0x%llx\n",
+ prev_cpu, cpu - 1, prev_val);
+
+ cnt += len;
+ if (!len)
+ break; /* Out of buffer */
+next:
+ prev_cpu = cpu;
+ prev_val = val;
+ }
+
+ if (prev_cpu == cpu - 1)
+ cnt += snprintf(buf + cnt, bufsiz - cnt, "CPU %d: 0x%llx\n",
+ prev_cpu, prev_val);
+ else
+ cnt += snprintf(buf + cnt, bufsiz - cnt, "CPUs %d-%d: 0x%llx\n",
+ prev_cpu, cpu - 1, prev_val);
+
+ count = simple_read_from_buffer(user_buf, count, ppos, buf, cnt);
+ kfree(buf);
+ return count;
+}
+
+static const struct file_operations fops_spec_ctrl = {
+ .read = spec_ctrl_msrs_read,
+ .llseek = default_llseek,
+};
+
+static int __init init_spec_ctrl_debugfs(void)
+{
+ if (!debugfs_create_file("spec_ctrl_msrs", 0400, arch_debugfs_dir,
+ NULL, &fops_spec_ctrl))
+ return -ENOMEM;
+ return 0;
+}
+fs_initcall(init_spec_ctrl_debugfs);
+#endif
+
#undef pr_fmt
#define pr_fmt(fmt) "Speculative Store Bypass: " fmt
--
2.31.1
next prev parent reply other threads:[~2023-06-20 14:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 14:06 [PATCH v2 0/5] x86/speculation: Disable IBRS when idle Waiman Long
2023-06-20 14:06 ` Waiman Long [this message]
2023-06-21 7:41 ` [PATCH v2 1/5] x86/speculation: Provide a debugfs file to dump SPEC_CTRL MSRs Peter Zijlstra
2023-06-21 8:24 ` Borislav Petkov
2023-06-21 14:02 ` Waiman Long
2023-06-21 13:47 ` Waiman Long
2023-06-20 14:06 ` [PATCH v2 2/5] x86/idle: Disable IBRS when cpu is offline Waiman Long
2023-06-21 7:23 ` Peter Zijlstra
2023-06-21 13:59 ` Waiman Long
2023-06-21 14:36 ` Peter Zijlstra
2023-06-21 14:44 ` Waiman Long
2023-06-21 14:48 ` Peter Zijlstra
2023-06-21 14:51 ` Waiman Long
2023-06-21 14:54 ` Peter Zijlstra
2023-06-21 15:42 ` Waiman Long
2023-06-20 14:06 ` [PATCH v2 3/5] intel_idle: Sync up the SPEC_CTRL MSR value to x86_spec_ctrl_current Waiman Long
2023-06-21 7:38 ` Peter Zijlstra
2023-06-20 14:06 ` [PATCH v2 4/5] intel_idle: Add no_ibrs module parameter to force disable IBRS Waiman Long
2023-06-21 7:30 ` Peter Zijlstra
2023-06-20 14:06 ` [PATCH v2 5/5] x86/idle: Disable IBRS entering mwait idle and enable it on wakeup Waiman Long
2023-06-21 7:32 ` Peter Zijlstra
2023-06-21 14:05 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620140625.1001886-2-longman@redhat.com \
--to=longman@redhat.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jmario@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=rjarry@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).