* [PATCH] OPP: Use dev_err_probe() when failing to get icc_path
@ 2023-06-23 15:53 Andrew Halaney
2023-06-26 6:40 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Halaney @ 2023-06-23 15:53 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-pm, sboyd, nm, vireshk, Andrew Halaney
This, in tandem with dynamic debug, can print useful information about
-EPROBE_DEFFER like below, and keeps similar behavior for other errors:
[ 16.561072] cpu cpu0: error -EPROBE_DEFER: dev_pm_opp_of_find_icc_paths: Unable to get path0
[ 16.575777] platform 18591000.cpufreq: deferred probe pending
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
drivers/opp/of.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index e6d1155d0990..1f0923cc1cd9 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -513,11 +513,7 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev,
for (i = 0; i < num_paths; i++) {
paths[i] = of_icc_get_by_index(dev, i);
if (IS_ERR(paths[i])) {
- ret = PTR_ERR(paths[i]);
- if (ret != -EPROBE_DEFER) {
- dev_err(dev, "%s: Unable to get path%d: %d\n",
- __func__, i, ret);
- }
+ ret = dev_err_probe(dev, ret, "%s: Unable to get path%d\n", __func__, i);
goto err;
}
}
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] OPP: Use dev_err_probe() when failing to get icc_path
2023-06-23 15:53 [PATCH] OPP: Use dev_err_probe() when failing to get icc_path Andrew Halaney
@ 2023-06-26 6:40 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2023-06-26 6:40 UTC (permalink / raw)
To: Andrew Halaney; +Cc: linux-kernel, linux-pm, sboyd, nm, vireshk
On 23-06-23, 10:53, Andrew Halaney wrote:
> This, in tandem with dynamic debug, can print useful information about
> -EPROBE_DEFFER like below, and keeps similar behavior for other errors:
>
> [ 16.561072] cpu cpu0: error -EPROBE_DEFER: dev_pm_opp_of_find_icc_paths: Unable to get path0
> [ 16.575777] platform 18591000.cpufreq: deferred probe pending
>
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
> drivers/opp/of.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index e6d1155d0990..1f0923cc1cd9 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -513,11 +513,7 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev,
> for (i = 0; i < num_paths; i++) {
> paths[i] = of_icc_get_by_index(dev, i);
> if (IS_ERR(paths[i])) {
> - ret = PTR_ERR(paths[i]);
> - if (ret != -EPROBE_DEFER) {
> - dev_err(dev, "%s: Unable to get path%d: %d\n",
> - __func__, i, ret);
> - }
> + ret = dev_err_probe(dev, ret, "%s: Unable to get path%d\n", __func__, i);
> goto err;
> }
> }
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-26 6:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-23 15:53 [PATCH] OPP: Use dev_err_probe() when failing to get icc_path Andrew Halaney
2023-06-26 6:40 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).