From: Yangtao Li <frank.li@vivo.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Yangtao Li" <frank.li@vivo.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 17/19] cpufreq: acpi: Convert to platform remove callback returning void
Date: Wed, 12 Jul 2023 17:33:20 +0800 [thread overview]
Message-ID: <20230712093322.37322-17-frank.li@vivo.com> (raw)
In-Reply-To: <20230712093322.37322-1-frank.li@vivo.com>
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
drivers/cpufreq/acpi-cpufreq.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
index b2f05d27167e..37f1cdf46d29 100644
--- a/drivers/cpufreq/acpi-cpufreq.c
+++ b/drivers/cpufreq/acpi-cpufreq.c
@@ -1011,22 +1011,20 @@ static int __init acpi_cpufreq_probe(struct platform_device *pdev)
return ret;
}
-static int acpi_cpufreq_remove(struct platform_device *pdev)
+static void acpi_cpufreq_remove(struct platform_device *pdev)
{
pr_debug("%s\n", __func__);
cpufreq_unregister_driver(&acpi_cpufreq_driver);
free_acpi_perf_data();
-
- return 0;
}
static struct platform_driver acpi_cpufreq_platdrv = {
.driver = {
.name = "acpi-cpufreq",
},
- .remove = acpi_cpufreq_remove,
+ .remove_new = acpi_cpufreq_remove,
};
static int __init acpi_cpufreq_init(void)
--
2.39.0
next prev parent reply other threads:[~2023-07-12 9:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 9:33 [PATCH 01/19] cpufreq: sun50i: Convert to platform remove callback returning void Yangtao Li
2023-07-12 9:33 ` [PATCH 02/19] cpufreq: dt: " Yangtao Li
2023-07-12 9:33 ` [PATCH 03/19] cpufreq: qcom-cpufreq-hw: " Yangtao Li
2023-07-12 9:33 ` [PATCH 04/19] cpufreq: vexpress: " Yangtao Li
2023-07-13 13:04 ` Sudeep Holla
2023-07-12 9:33 ` [PATCH 05/19] cpufreq: imx6q: " Yangtao Li
2023-07-12 9:33 ` [PATCH 06/19] cpufreq: mediatek-hw: " Yangtao Li
2023-07-12 9:33 ` [PATCH 07/19] cpufreq: scpi: " Yangtao Li
2023-07-13 13:06 ` Sudeep Holla
2023-07-12 9:33 ` [PATCH 08/19] cpufreq: tegra194: " Yangtao Li
2023-07-12 9:33 ` [PATCH 09/19] cpufreq: brcmstb-avs-cpufreq: " Yangtao Li
2023-07-12 15:38 ` Florian Fainelli
2023-07-12 9:33 ` [PATCH 10/19] cpufreq: imx-cpufreq-dt: " Yangtao Li
2023-07-12 9:33 ` [PATCH 11/19] cpufreq: davinci: " Yangtao Li
2023-07-12 9:33 ` [PATCH 12/19] cpufreq: raspberrypi: " Yangtao Li
2023-07-12 15:38 ` Florian Fainelli
2023-07-12 9:33 ` [PATCH 13/19] cpufreq: pcc-cpufreq: " Yangtao Li
2023-07-14 18:59 ` Rafael J. Wysocki
2023-07-12 9:33 ` [PATCH 14/19] cpufreq: kirkwood: " Yangtao Li
2023-07-12 9:33 ` [PATCH 15/19] cpufreq: qcom-nvmem: " Yangtao Li
2023-07-12 9:33 ` [PATCH 16/19] cpufreq: tegra186: " Yangtao Li
2023-07-12 9:33 ` Yangtao Li [this message]
2023-07-14 18:57 ` [PATCH 17/19] cpufreq: acpi: " Rafael J. Wysocki
2023-07-12 9:33 ` [PATCH 18/19] cpufreq: qoriq: " Yangtao Li
2023-07-12 9:33 ` [PATCH 19/19] cpufreq: omap: " Yangtao Li
2023-07-12 16:05 ` [PATCH 01/19] cpufreq: sun50i: " Jernej Škrabec
2023-07-20 10:32 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712093322.37322-17-frank.li@vivo.com \
--to=frank.li@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox