From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43C6AC001B0 for ; Fri, 14 Jul 2023 07:19:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235365AbjGNHTz (ORCPT ); Fri, 14 Jul 2023 03:19:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235377AbjGNHTv (ORCPT ); Fri, 14 Jul 2023 03:19:51 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E21C530EF; Fri, 14 Jul 2023 00:19:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id BC6E380A8; Fri, 14 Jul 2023 07:19:36 +0000 (UTC) Date: Fri, 14 Jul 2023 10:19:35 +0300 From: Tony Lindgren To: Johan Hovold Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , Pavel Machek , Len Brown , Andy Gross , Bjorn Andersson , Konrad Dybcio , Jiri Slaby , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 2/3] PM / wakeirq: drop unused enable helpers Message-ID: <20230714071935.GA5194@atomide.com> References: <20230713145741.30390-1-johan+linaro@kernel.org> <20230713145741.30390-3-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230713145741.30390-3-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org * Johan Hovold [230713 15:01]: > Drop the wake-irq enable and disable helpers which have not been used > since commit bed570307ed7 ("PM / wakeirq: Fix dedicated wakeirq for > drivers not using autosuspend"). > > Note that these functions are essentially just leftovers from the first > iteration of the wake-irq implementation where device drivers were > supposed to call these functions themselves instead of PM core (as > is also indicated by the bogus kernel doc comments). Agreed no need for these any longer: Reviewed-by: Tony Lindgren