From: Tony Lindgren <tony@atomide.com>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/3] PM / wakeirq: fix wake irq arming
Date: Fri, 14 Jul 2023 10:48:11 +0300 [thread overview]
Message-ID: <20230714074811.GC5194@atomide.com> (raw)
In-Reply-To: <20230713145741.30390-2-johan+linaro@kernel.org>
* Johan Hovold <johan+linaro@kernel.org> [230713 15:01]:
> The decision whether to enable a wake irq during suspend can not be done
> based on the runtime PM state directly as a driver may use wake irqs
> without implementing runtime PM. Such drivers specifically leave the
> state set to the default 'suspended' and the wake irq is thus never
> enabled at suspend.
>
> Add a new wake irq flag to track whether a dedicated wake irq has been
> enabled at runtime suspend and therefore must not be enabled at system
> suspend.
>
> Note that pm_runtime_enabled() can not be used as runtime PM is always
> disabled during late suspend.
Works for me:
Reviewed-by: Tony Lindgren <tony@atomide.com>
Tested-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2023-07-14 7:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 14:57 [PATCH 0/3] PM / wakeirq: fix wake irq arming Johan Hovold
2023-07-13 14:57 ` [PATCH 1/3] " Johan Hovold
2023-07-14 7:48 ` Tony Lindgren [this message]
2023-07-13 14:57 ` [PATCH 2/3] PM / wakeirq: drop unused enable helpers Johan Hovold
2023-07-14 7:19 ` Tony Lindgren
2023-07-13 14:57 ` [PATCH 3/3] serial: qcom-geni: drop bogus runtime pm state update Johan Hovold
2023-07-14 7:20 ` Tony Lindgren
2023-07-20 17:49 ` [PATCH 0/3] PM / wakeirq: fix wake irq arming Rafael J. Wysocki
2023-08-01 5:48 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230714074811.GC5194@atomide.com \
--to=tony@atomide.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=len.brown@intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).