From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E67DCC001B0 for ; Fri, 14 Jul 2023 07:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234764AbjGNHsO (ORCPT ); Fri, 14 Jul 2023 03:48:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234985AbjGNHsN (ORCPT ); Fri, 14 Jul 2023 03:48:13 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2DCEE30DC; Fri, 14 Jul 2023 00:48:13 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 73E4C80A8; Fri, 14 Jul 2023 07:48:12 +0000 (UTC) Date: Fri, 14 Jul 2023 10:48:11 +0300 From: Tony Lindgren To: Johan Hovold Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , Pavel Machek , Len Brown , Andy Gross , Bjorn Andersson , Konrad Dybcio , Jiri Slaby , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] PM / wakeirq: fix wake irq arming Message-ID: <20230714074811.GC5194@atomide.com> References: <20230713145741.30390-1-johan+linaro@kernel.org> <20230713145741.30390-2-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230713145741.30390-2-johan+linaro@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org * Johan Hovold [230713 15:01]: > The decision whether to enable a wake irq during suspend can not be done > based on the runtime PM state directly as a driver may use wake irqs > without implementing runtime PM. Such drivers specifically leave the > state set to the default 'suspended' and the wake irq is thus never > enabled at suspend. > > Add a new wake irq flag to track whether a dedicated wake irq has been > enabled at runtime suspend and therefore must not be enabled at system > suspend. > > Note that pm_runtime_enabled() can not be used as runtime PM is always > disabled during late suspend. Works for me: Reviewed-by: Tony Lindgren Tested-by: Tony Lindgren