From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02381C0015E for ; Fri, 21 Jul 2023 11:56:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230368AbjGUL4L (ORCPT ); Fri, 21 Jul 2023 07:56:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230362AbjGUL4K (ORCPT ); Fri, 21 Jul 2023 07:56:10 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C3F002D75; Fri, 21 Jul 2023 04:56:06 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9E0132F4; Fri, 21 Jul 2023 04:56:49 -0700 (PDT) Received: from bogus (unknown [10.57.96.100]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D467C3F6C4; Fri, 21 Jul 2023 04:56:02 -0700 (PDT) Date: Fri, 21 Jul 2023 12:55:35 +0100 From: Sudeep Holla To: Ulf Hansson Cc: Cristian Marussi , Viresh Kumar , Nishanth Menon , Stephen Boyd , Nikunj Kela , Sudeep Holla , Prasad Sodagudi , Alexandre Torgue , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org Subject: Re: [PATCH v2 08/11] dt-bindings: firmware: arm,scmi: Extend bindings for protocol@13 Message-ID: <20230721115535.mx46dg56pxjnzbuv@bogus> References: <20230713141738.23970-1-ulf.hansson@linaro.org> <20230713141738.23970-9-ulf.hansson@linaro.org> <20230719151716.qhobfnclrjf4yqkg@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Jul 21, 2023 at 01:42:43PM +0200, Ulf Hansson wrote: > On Wed, 19 Jul 2023 at 17:17, Sudeep Holla wrote: > > > > On Thu, Jul 13, 2023 at 04:17:35PM +0200, Ulf Hansson wrote: > > > The protocol@13 node is describing the performance scaling option for the > > > ARM SCMI interface, as a clock provider. This is unnecessary limiting, as > > > performance scaling is in many cases not limited to switching a clock's > > > frequency. > > > > > > Therefore, let's extend the binding so the interface can be modelled as a > > > generic performance domaintoo. The common way to describe this, is to use > > > the "power-domain" DT bindings, so let's use that. > > > > > > > One thing I forgot to ask earlier is how we can manage different domain IDs > > for perf and power domains which is the case with current SCMI platforms as > > the spec never mandated or can ever mandate the perf and power domains IDs > > to match. They need not be same anyways. > > Based upon what you describe above, I have modelled the perf-domain > and the power-domain as two separate power-domain providers. > > A consumer device being hooked up to both domains, would specify the > domain IDs in the second power-domain-cell, along the lines of the > below. Then we would use power-domain-names to specify what each > power-domain represents. > > power-domains = <&scmi_pd 2>, <&scmi_dvfs 4>; > power-domain-names = "power", "perf"; > > I hope this makes it clearer!? Yes it make is clear definitely, but it does change the definition of the generic binding of the "power-domains" property now. I am interesting in the feedback from the binding maintainers with respect to that. Or is it already present ? IIUC, the ones supported already are generally both power and performance providers. May be it doesn't matter much, just wanted to explicit ask and confirm those details. -- Regards, Sudeep