From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39465C0015E for ; Mon, 24 Jul 2023 06:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230271AbjGXG1H (ORCPT ); Mon, 24 Jul 2023 02:27:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbjGXG1G (ORCPT ); Mon, 24 Jul 2023 02:27:06 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A05BB0 for ; Sun, 23 Jul 2023 23:27:05 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6687096c6ddso2094218b3a.0 for ; Sun, 23 Jul 2023 23:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690180025; x=1690784825; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=HfDDHnCKWhdZT7WnmbTsFLDNkDDnfliPEm42Q1iIO1E=; b=Uj1BQcrbEcHyq/7C73guHDmA5J5L0a4dtwU0SmnX3qKIHEZ/yqJ5oLO2F7eLAhur5M Fo+DWNAsWb64a7DyhqoMcpEOOxg3RHeHzmWKdnjVYVf9QpF8sr6xAZOjfkadG/kPxwJ8 jHuFE8jsDZtlQ4y8wr2a7CAaAZ5yLE6YylQCLV6ghBNk4oLxSrPJ8gSP9+dWeaNBZbq/ EqSXjn2SwqXak0RbXkfm778C7FEmzX1ntnjo/P/lA0+ZMPf15ojjMjYV+IqH7ASsTUKg HCDyq01v5iasPyEeIUDCF9eUS1nzYE7rPAEVfh13FcR80ANKR27dStUTxFqakOjps7jo 2G1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690180025; x=1690784825; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HfDDHnCKWhdZT7WnmbTsFLDNkDDnfliPEm42Q1iIO1E=; b=d5kpl6wjvOAdxOtjoHroR0m4m/13zT0cS9qk9XRUA/ryB9lKkYOqErVstuF/Gr/Gfh lHglLhZOLEPj6DLX13RVos7gVEYuIwMxH/6G5spZ5HLwu/Rw4i1yEAZt44paRSF95Cpx Ph8SrjcKVtNdmvHEQhT4F7C39Iy0xbUyIcNHnZv11OFqxtWdRoN5lxxHLLcpPiSM/hLm Xtl0rnbhfVP4ah4OrPhZT8I6T6Bk8D/SEJD5ogjlOXRHjWkQRGkYGRXAT1+THTy5xm0H 1RDBfeu/4k8Vq92dnPCAY3cr/h1Me/R6ciE9z5hZqBSAKhJ5YnUhtryMmNcnAY/PEBS+ TORg== X-Gm-Message-State: ABy/qLZ40zr3LJqiiK1kBiaQbcvfAX0g8nz3T7CWhDsZiVeBC2kqTgcP ItNtU3XydRHYGDP53fLzGFwWG2pLqGmXCf9X2Q== X-Google-Smtp-Source: APBJJlE3/Al5UAXKEW44LeHM76v7K4EvCJ1qp2x4AM9HUJmAfcTkFwhsbcTxhmRxYtsaYqpwXvzf1w== X-Received: by 2002:a05:6a00:1398:b0:662:f0d0:a77d with SMTP id t24-20020a056a00139800b00662f0d0a77dmr5282853pfg.30.1690180024787; Sun, 23 Jul 2023 23:27:04 -0700 (PDT) Received: from thinkpad ([117.206.118.29]) by smtp.gmail.com with ESMTPSA id s21-20020a62e715000000b00678afd4824asm7082283pfh.175.2023.07.23.23.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Jul 2023 23:27:04 -0700 (PDT) Date: Mon, 24 Jul 2023 11:56:57 +0530 From: Manivannan Sadhasivam To: Viresh Kumar Cc: Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , linux-pm@vger.kernel.org, Vincent Guittot , linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] OPP: Reuse dev_pm_opp_get_freq_indexed() Message-ID: <20230724062657.GL2370@thinkpad> References: <5ddded46303f9d034ecb79f1fcc48abcc590f7db.1689932341.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5ddded46303f9d034ecb79f1fcc48abcc590f7db.1689932341.git.viresh.kumar@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Jul 21, 2023 at 03:10:59PM +0530, Viresh Kumar wrote: > Reuse dev_pm_opp_get_freq_indexed() from dev_pm_opp_get_freq(). > > Signed-off-by: Viresh Kumar Acked-by: Manivannan Sadhasivam - Mani > --- > drivers/opp/core.c | 21 --------------------- > include/linux/pm_opp.h | 12 +++++------- > 2 files changed, 5 insertions(+), 28 deletions(-) > > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > index 95f49fbe431c..16a103e6695b 100644 > --- a/drivers/opp/core.c > +++ b/drivers/opp/core.c > @@ -176,27 +176,6 @@ unsigned long dev_pm_opp_get_power(struct dev_pm_opp *opp) > } > EXPORT_SYMBOL_GPL(dev_pm_opp_get_power); > > -/** > - * dev_pm_opp_get_freq() - Gets the frequency corresponding to an available opp > - * @opp: opp for which frequency has to be returned for > - * > - * Return: frequency in hertz corresponding to the opp, else > - * return 0 > - */ > -unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp) > -{ > - if (IS_ERR_OR_NULL(opp)) { > - pr_err("%s: Invalid parameters\n", __func__); > - return 0; > - } > - > - if (!assert_single_clk(opp->opp_table)) > - return 0; > - > - return opp->rates[0]; > -} > -EXPORT_SYMBOL_GPL(dev_pm_opp_get_freq); > - > /** > * dev_pm_opp_get_freq_indexed() - Gets the frequency corresponding to an > * available opp with specified index > diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h > index 23e4e4eaaa42..91f87d7e807c 100644 > --- a/include/linux/pm_opp.h > +++ b/include/linux/pm_opp.h > @@ -103,8 +103,6 @@ int dev_pm_opp_get_supplies(struct dev_pm_opp *opp, struct dev_pm_opp_supply *su > > unsigned long dev_pm_opp_get_power(struct dev_pm_opp *opp); > > -unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp); > - > unsigned long dev_pm_opp_get_freq_indexed(struct dev_pm_opp *opp, u32 index); > > unsigned int dev_pm_opp_get_level(struct dev_pm_opp *opp); > @@ -214,11 +212,6 @@ static inline unsigned long dev_pm_opp_get_power(struct dev_pm_opp *opp) > return 0; > } > > -static inline unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp) > -{ > - return 0; > -} > - > static inline unsigned long dev_pm_opp_get_freq_indexed(struct dev_pm_opp *opp, u32 index) > { > return 0; > @@ -669,4 +662,9 @@ static inline void dev_pm_opp_put_prop_name(int token) > dev_pm_opp_clear_config(token); > } > > +static inline unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp) > +{ > + return dev_pm_opp_get_freq_indexed(opp, 0); > +} > + > #endif /* __LINUX_OPP_H__ */ > -- > 2.31.1.272.g89b43f80a514 > -- மணிவண்ணன் சதாசிவம்