public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Nikita Travkin <nikita@trvn.ru>,
	Sebastian Reichel <sre@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, Nikita Travkin <nikita@trvn.ru>
Subject: Re: [PATCH 4/4] power: supply: Add driver for pm8916 lbc
Date: Sat, 29 Jul 2023 13:28:14 +0800	[thread overview]
Message-ID: <202307291336.Zxmj8R1g-lkp@intel.com> (raw)
In-Reply-To: <20230728-pm8916-bms-lbc-v1-4-56da32467487@trvn.ru>

Hi Nikita,

kernel test robot noticed the following build warnings:

[auto build test WARNING on d7b3af5a77e8d8da28f435f313e069aea5bcf172]

url:    https://github.com/intel-lab-lkp/linux/commits/Nikita-Travkin/dt-bindings-power-supply-Add-pm8916-VM-BMS/20230729-013044
base:   d7b3af5a77e8d8da28f435f313e069aea5bcf172
patch link:    https://lore.kernel.org/r/20230728-pm8916-bms-lbc-v1-4-56da32467487%40trvn.ru
patch subject: [PATCH 4/4] power: supply: Add driver for pm8916 lbc
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230729/202307291336.Zxmj8R1g-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230729/202307291336.Zxmj8R1g-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307291336.Zxmj8R1g-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/power/supply/pm8916_lbc.c: In function 'pm8916_lbc_charger_get_property':
>> drivers/power/supply/pm8916_lbc.c:130:22: warning: unused variable 'tmp' [-Wunused-variable]
     130 |         unsigned int tmp;
         |                      ^~~
>> drivers/power/supply/pm8916_lbc.c:129:13: warning: unused variable 'ret' [-Wunused-variable]
     129 |         int ret = 0;
         |             ^~~


vim +/tmp +130 drivers/power/supply/pm8916_lbc.c

   123	
   124	static int pm8916_lbc_charger_get_property(struct power_supply *psy,
   125						   enum power_supply_property psp,
   126						   union power_supply_propval *val)
   127	{
   128		struct pm8916_lbc_charger *chg = power_supply_get_drvdata(psy);
 > 129		int ret = 0;
 > 130		unsigned int tmp;
   131	
   132		switch (psp) {
   133		case POWER_SUPPLY_PROP_ONLINE:
   134			val->intval = chg->online;
   135			return 0;
   136	
   137		case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX:
   138			val->intval = chg->charge_voltage_max;
   139			return 0;
   140	
   141		case POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT:
   142			val->intval = chg->charge_current_max;
   143			return 0;
   144	
   145		default:
   146			return -EINVAL;
   147		};
   148	}
   149	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      reply	other threads:[~2023-07-29  5:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28 17:19 [PATCH 0/4] Add pm8916 VM-BMS and LBC Nikita Travkin
2023-07-28 17:19 ` [PATCH 1/4] dt-bindings: power: supply: Add pm8916 VM-BMS Nikita Travkin
2023-07-29 10:03   ` Conor Dooley
2023-07-29 12:06     ` Nikita Travkin
2023-07-29 12:10       ` Conor Dooley
2023-07-29 12:15         ` Nikita Travkin
2023-07-30 10:05           ` Conor Dooley
2023-07-28 17:19 ` [PATCH 2/4] dt-bindings: power: supply: Add pm8916 LBC Nikita Travkin
2023-07-28 17:19 ` [PATCH 3/4] power: supply: Add pm8916 VM-BMS support Nikita Travkin
2023-07-28 17:19 ` [PATCH 4/4] power: supply: Add driver for pm8916 lbc Nikita Travkin
2023-07-29  5:28   ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202307291336.Zxmj8R1g-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=nikita@trvn.ru \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox