Re: [PATCH V3 2/2] dt-bindings: cpufreq: Convert ti-cpufreq to json schema

Dhruva Gole
2023-08-09T04:30:29Z

On Aug 08, 2023 at 21:30:45 -0500, Nishanth Menon wrote:
> Move the ti-cpufreq binding over to opp and convert the free text
> binding to json-schema.
>
> Reviewed-by: Dhruva Gole <d-gole@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Changes since V2:
> * Just fixup for commit message and picked up Reviewed-by from Dhruva.
>
> V2: https://lore.kernel.org/r/20230801233341.1416552-3-nm@ti.com
> V1: https://lore.kernel.org/all/20230724153911.1376830-6-nm@ti.com/
>
> Side note: Cleanups in dt is picked up on Tony's tree:
> https://lore.kernel.org/all/20230731062551.GH5194@atomide.com/
>
> .../bindings/cpufreq/ti-cpufreq.txt | 132 ------------------
> .../opp/operating-points-v2-ti-cpu.yaml | 88 ++++++++++++
> 2 files changed, 88 insertions(+), 132 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
> create mode 100644 Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml
>
[...]
> new file mode 100644
> index 000000000000..ada57bfc1da9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/opp/operating-points-v2-ti-cpu.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/opp/operating-points-v2-ti-cpu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI CPU OPP (Operating Performance Points)
> +
> +description:
> + Certain TI SoCs, like those in the am335x, am437x, am57xx, am62x and dra7xx
> + families support different OPPs depending on the silicon variant in use.
> + The ti-cpufreq driver can use revision and an efuse value from the SoC to

Just learned about this yesterday, hence missed it in my earlier review.
Looks like the kernel docs [0] say that we DON'T refer to Linux or
"device driver" in bindings.

Bindings should be based on what the hardware has, not what an OS and
driver currently support.

> + provide the OPP framework with supported hardware information. This is
> + used to determine which OPPs from the operating-points-v2 table get enabled
> + when it is parsed by the OPP framework.
> +
[...]

[0] https://docs.kernel.org/devicetree/bindings/writing-bindings.html

--
Best regards,
Dhruva Gole <d-gole@ti.com>