Re: [PATCH V3 1/2] dt-bindings: opp: Convert ti-omap5-opp-supply to json schema

Dhruva Gole
2023-08-09T04:48:44Z

On Aug 08, 2023 at 21:30:44 -0500, Nishanth Menon wrote:
> Rename ti-omap5-opp-supply to be bit more generic omap-opp-supply and
> convert the free text binding to json-schema.
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Changes since V2:
> - None.
>
> V2: https://lore.kernel.org/r/20230801233341.1416552-2-nm@ti.com
> V1: https://lore.kernel.org/all/20230724153911.1376830-5-nm@ti.com/
> .../bindings/opp/ti,omap-opp-supply.yaml | 103 ++++++++++++++++++
> .../bindings/opp/ti-omap5-opp-supply.txt | 63 -----------
> 2 files changed, 103 insertions(+), 63 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml
> delete mode 100644 Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt
>
> diff --git a/Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml b/Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml
> new file mode 100644
> index 000000000000..4db80e418829
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/opp/ti,omap-opp-supply.yaml
> @@ -0,0 +1,103 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/opp/ti,omap-opp-supply.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments OMAP compatible OPP supply
> +
> +description:
> + OMAP5, DRA7, and AM57 family of SoCs have Class0 AVS eFuse registers which
> + contain data that can be used to adjust voltages programmed for some of their
> + supplies for more efficient operation. This binding provides the information
> + needed to read these values and use them to program the main regulator during
> + an OPP transitions.
> +
> + Also, some supplies may have an associated vbb-supply which is an Adaptive Body
> + Bias regulator which much be transitioned in a specific sequence with regards

s/much/must ?

> + to the vdd-supply and clk when making an OPP transition. By supplying two
> + regulators to the device that will undergo OPP transitions we can make use
> + of the multi regulator binding that is part of the OPP core described

Existing txt seems to have:

part of the OPP core described here [1]

Why get rid of the reference "[1]" here?

Going through Documentation/devicetree/bindings/opp/opp-v2.yaml didn't
tell me much about this multi regulator binding, I only see 1 example.

Please can you explain a bit more or make this line more clear?

> + to describe both regulators needed by the platform.
> +
> +maintainers:
> + - Nishanth Menon <nm@ti.com>
> +
> +properties:
> + $nodename:
> + pattern: '^opp-supply(@[0-9a-f]+)?$'
[...]

--
Best regards,
Dhruva Gole <d-gole@ti.com>