* [PATCH 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict
@ 2023-08-22 13:22 Grant B Adams
2023-08-22 14:42 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Grant B Adams @ 2023-08-22 13:22 UTC (permalink / raw)
Cc: linux-omap, tony, Grant B Adams, Sebastian Reichel, Bin Liu,
Greg Kroah-Hartman, linux-pm, linux-kernel, linux-usb
Enabling the tps65217-charger driver/module causes an interrupt conflict
with the vbus driver resulting in a probe failure.
The conflict is resolved by changing both driver's threaded interrupt
request function from IRQF_ONESHOT to IRQF_SHARED.
Signed-off-by: Grant B Adams <nemith592@gmail.com>
---
drivers/usb/musb/musb_dsps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
index 9119b1d51370..cbb45de5a76f 100644
--- a/drivers/usb/musb/musb_dsps.c
+++ b/drivers/usb/musb/musb_dsps.c
@@ -851,7 +851,7 @@ static int dsps_setup_optional_vbus_irq(struct platform_device *pdev,
error = devm_request_threaded_irq(glue->dev, glue->vbus_irq,
NULL, dsps_vbus_threaded_irq,
- IRQF_ONESHOT,
+ IRQF_SHARED,
"vbus", glue);
if (error) {
glue->vbus_irq = 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict
2023-08-22 13:22 [PATCH 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict Grant B Adams
@ 2023-08-22 14:42 ` Greg Kroah-Hartman
[not found] ` <CAMg76N62CQq=VJ7jXHN4UnAv0NKo89VYnEJmVMXGPLzg8nvyag@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2023-08-22 14:42 UTC (permalink / raw)
To: Grant B Adams
Cc: linux-omap, tony, Sebastian Reichel, Bin Liu, linux-pm,
linux-kernel, linux-usb
On Tue, Aug 22, 2023 at 03:22:02PM +0200, Grant B Adams wrote:
> Enabling the tps65217-charger driver/module causes an interrupt conflict
> with the vbus driver resulting in a probe failure.
> The conflict is resolved by changing both driver's threaded interrupt
> request function from IRQF_ONESHOT to IRQF_SHARED.
>
> Signed-off-by: Grant B Adams <nemith592@gmail.com>
> ---
> drivers/usb/musb/musb_dsps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> index 9119b1d51370..cbb45de5a76f 100644
> --- a/drivers/usb/musb/musb_dsps.c
> +++ b/drivers/usb/musb/musb_dsps.c
> @@ -851,7 +851,7 @@ static int dsps_setup_optional_vbus_irq(struct platform_device *pdev,
>
> error = devm_request_threaded_irq(glue->dev, glue->vbus_irq,
> NULL, dsps_vbus_threaded_irq,
> - IRQF_ONESHOT,
> + IRQF_SHARED,
> "vbus", glue);
> if (error) {
> glue->vbus_irq = 0;
> --
> 2.34.1
>
Why is the patch here talking about the tps65217-charger driver? That's
totally independent.
Also, your patches are not threaded, how did you send them? Are they
related in some way or not?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict
[not found] ` <CAMg76N62CQq=VJ7jXHN4UnAv0NKo89VYnEJmVMXGPLzg8nvyag@mail.gmail.com>
@ 2023-08-22 18:46 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2023-08-22 18:46 UTC (permalink / raw)
To: Grant Adams
Cc: linux-omap, tony, Sebastian Reichel, Bin Liu, linux-pm,
linux-kernel, linux-usb
On Tue, Aug 22, 2023 at 08:20:56PM +0200, Grant Adams wrote:
> On Tue, Aug 22, 2023 at 4:42 PM Greg Kroah-Hartman <
> gregkh@linuxfoundation.org> wrote:
>
> > On Tue, Aug 22, 2023 at 03:22:02PM +0200, Grant B Adams wrote:
> > > Enabling the tps65217-charger driver/module causes an interrupt conflict
> > > with the vbus driver resulting in a probe failure.
> > > The conflict is resolved by changing both driver's threaded interrupt
> > > request function from IRQF_ONESHOT to IRQF_SHARED.
> > >
> > > Signed-off-by: Grant B Adams <nemith592@gmail.com>
> > > ---
> > > drivers/usb/musb/musb_dsps.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> > > index 9119b1d51370..cbb45de5a76f 100644
> > > --- a/drivers/usb/musb/musb_dsps.c
> > > +++ b/drivers/usb/musb/musb_dsps.c
> > > @@ -851,7 +851,7 @@ static int dsps_setup_optional_vbus_irq(struct
> > platform_device *pdev,
> > >
> > > error = devm_request_threaded_irq(glue->dev, glue->vbus_irq,
> > > NULL, dsps_vbus_threaded_irq,
> > > - IRQF_ONESHOT,
> > > + IRQF_SHARED,
> > > "vbus", glue);
> > > if (error) {
> > > glue->vbus_irq = 0;
> > > --
> > > 2.34.1
> > >
> >
> > Why is the patch here talking about the tps65217-charger driver? That's
> > totally independent.
> >
> > Also, your patches are not threaded, how did you send them? Are they
> > related in some way or not?
> >
> > thanks,
> >
> > greg k-h
> >
>
> Apologies Greg,
>
> This is my first patch and did not know about creating email threads for
> multiple patches. I'll create an email thread for the patches and will
> provide
> an overview and better context in [PATCH 0/2].
That would be great, be sure to number this a v2 patch series as the
documentation asks for as well :)
good luck!
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-22 18:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-22 13:22 [PATCH 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict Grant B Adams
2023-08-22 14:42 ` Greg Kroah-Hartman
[not found] ` <CAMg76N62CQq=VJ7jXHN4UnAv0NKo89VYnEJmVMXGPLzg8nvyag@mail.gmail.com>
2023-08-22 18:46 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).