From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Grant B Adams <nemith592@gmail.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
Sebastian Reichel <sre@kernel.org>, Bin Liu <b-liu@ti.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict
Date: Tue, 22 Aug 2023 16:42:39 +0200 [thread overview]
Message-ID: <2023082256-judiciary-udder-6d06@gregkh> (raw)
In-Reply-To: <20230822132202.19659-1-nemith592@gmail.com>
On Tue, Aug 22, 2023 at 03:22:02PM +0200, Grant B Adams wrote:
> Enabling the tps65217-charger driver/module causes an interrupt conflict
> with the vbus driver resulting in a probe failure.
> The conflict is resolved by changing both driver's threaded interrupt
> request function from IRQF_ONESHOT to IRQF_SHARED.
>
> Signed-off-by: Grant B Adams <nemith592@gmail.com>
> ---
> drivers/usb/musb/musb_dsps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> index 9119b1d51370..cbb45de5a76f 100644
> --- a/drivers/usb/musb/musb_dsps.c
> +++ b/drivers/usb/musb/musb_dsps.c
> @@ -851,7 +851,7 @@ static int dsps_setup_optional_vbus_irq(struct platform_device *pdev,
>
> error = devm_request_threaded_irq(glue->dev, glue->vbus_irq,
> NULL, dsps_vbus_threaded_irq,
> - IRQF_ONESHOT,
> + IRQF_SHARED,
> "vbus", glue);
> if (error) {
> glue->vbus_irq = 0;
> --
> 2.34.1
>
Why is the patch here talking about the tps65217-charger driver? That's
totally independent.
Also, your patches are not threaded, how did you send them? Are they
related in some way or not?
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-22 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 13:22 [PATCH 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict Grant B Adams
2023-08-22 14:42 ` Greg Kroah-Hartman [this message]
[not found] ` <CAMg76N62CQq=VJ7jXHN4UnAv0NKo89VYnEJmVMXGPLzg8nvyag@mail.gmail.com>
2023-08-22 18:46 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023082256-judiciary-udder-6d06@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=b-liu@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nemith592@gmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).