From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BF52EE49AA for ; Tue, 22 Aug 2023 14:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236890AbjHVOmq (ORCPT ); Tue, 22 Aug 2023 10:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236887AbjHVOmp (ORCPT ); Tue, 22 Aug 2023 10:42:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 043C8187; Tue, 22 Aug 2023 07:42:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8E2A46592A; Tue, 22 Aug 2023 14:42:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A521C433C9; Tue, 22 Aug 2023 14:42:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1692715362; bh=JwRaFdXpBFPQvWg+7PAhwk5RLTvKjoAS3evEC/T1Ics=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0euQLufgFNRSnjyplQRQhH6HbdZ16LqtVmuSb58MLZK863JtFKmETmzT7qsFuvx/1 7AZFXTdjbLMe+TvyViLIOikGnRQlyITSgy6SalJvI4fc9sZgJ1Gyv3f4zzqpVi5SkV rMT1Wl/QM+uKVEgvzVXFUQNMsQRQCzzhGz5Nl3IY= Date: Tue, 22 Aug 2023 16:42:39 +0200 From: Greg Kroah-Hartman To: Grant B Adams Cc: linux-omap@vger.kernel.org, tony@atomide.com, Sebastian Reichel , Bin Liu , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict Message-ID: <2023082256-judiciary-udder-6d06@gregkh> References: <20230822132202.19659-1-nemith592@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230822132202.19659-1-nemith592@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Aug 22, 2023 at 03:22:02PM +0200, Grant B Adams wrote: > Enabling the tps65217-charger driver/module causes an interrupt conflict > with the vbus driver resulting in a probe failure. > The conflict is resolved by changing both driver's threaded interrupt > request function from IRQF_ONESHOT to IRQF_SHARED. > > Signed-off-by: Grant B Adams > --- > drivers/usb/musb/musb_dsps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c > index 9119b1d51370..cbb45de5a76f 100644 > --- a/drivers/usb/musb/musb_dsps.c > +++ b/drivers/usb/musb/musb_dsps.c > @@ -851,7 +851,7 @@ static int dsps_setup_optional_vbus_irq(struct platform_device *pdev, > > error = devm_request_threaded_irq(glue->dev, glue->vbus_irq, > NULL, dsps_vbus_threaded_irq, > - IRQF_ONESHOT, > + IRQF_SHARED, > "vbus", glue); > if (error) { > glue->vbus_irq = 0; > -- > 2.34.1 > Why is the patch here talking about the tps65217-charger driver? That's totally independent. Also, your patches are not threaded, how did you send them? Are they related in some way or not? thanks, greg k-h