* [PATCH 1/2] dt-bindings: cpufreq: qcom-hw: add a 4th frequency domain
2023-08-21 7:39 [PATCH 0/2] qcom-cpufreq-hw: add support for 4 freq domains Neil Armstrong
@ 2023-08-21 7:39 ` Neil Armstrong
2023-08-23 8:07 ` Manivannan Sadhasivam
2023-08-23 13:16 ` Rob Herring
2023-08-21 7:39 ` [PATCH 2/2] cpufreq: qcom-cpufreq-hw: add support for 4 freq domains Neil Armstrong
2023-08-23 15:01 ` [PATCH 0/2] " Viresh Kumar
2 siblings, 2 replies; 7+ messages in thread
From: Neil Armstrong @ 2023-08-21 7:39 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Manivannan Sadhasivam, Andy Gross, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, devicetree, linux-kernel, linux-arm-msm, Neil Armstrong
On new platforms, a 4th frequency domain is used, document it.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
index a6b3bb8fdf33..c1d225fcf2d5 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
@@ -49,6 +49,7 @@ properties:
- description: Frequency domain 0 register region
- description: Frequency domain 1 register region
- description: Frequency domain 2 register region
+ - description: Frequency domain 3 register region
reg-names:
minItems: 1
@@ -56,6 +57,7 @@ properties:
- const: freq-domain0
- const: freq-domain1
- const: freq-domain2
+ - const: freq-domain3
clocks:
items:
@@ -69,7 +71,7 @@ properties:
interrupts:
minItems: 1
- maxItems: 3
+ maxItems: 4
interrupt-names:
minItems: 1
@@ -77,6 +79,7 @@ properties:
- const: dcvsh-irq-0
- const: dcvsh-irq-1
- const: dcvsh-irq-2
+ - const: dcvsh-irq-3
'#freq-domain-cells':
const: 1
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/2] dt-bindings: cpufreq: qcom-hw: add a 4th frequency domain
2023-08-21 7:39 ` [PATCH 1/2] dt-bindings: cpufreq: qcom-hw: add a 4th frequency domain Neil Armstrong
@ 2023-08-23 8:07 ` Manivannan Sadhasivam
2023-08-23 13:16 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Manivannan Sadhasivam @ 2023-08-23 8:07 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rafael J. Wysocki, Viresh Kumar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Andy Gross, Bjorn Andersson, Konrad Dybcio,
linux-pm, devicetree, linux-kernel, linux-arm-msm
On Mon, Aug 21, 2023 at 09:39:13AM +0200, Neil Armstrong wrote:
> On new platforms, a 4th frequency domain is used, document it.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Acked-by: Manivannan Sadhasivam <mani@kernel.org>
- Mani
> ---
> Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> index a6b3bb8fdf33..c1d225fcf2d5 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> @@ -49,6 +49,7 @@ properties:
> - description: Frequency domain 0 register region
> - description: Frequency domain 1 register region
> - description: Frequency domain 2 register region
> + - description: Frequency domain 3 register region
>
> reg-names:
> minItems: 1
> @@ -56,6 +57,7 @@ properties:
> - const: freq-domain0
> - const: freq-domain1
> - const: freq-domain2
> + - const: freq-domain3
>
> clocks:
> items:
> @@ -69,7 +71,7 @@ properties:
>
> interrupts:
> minItems: 1
> - maxItems: 3
> + maxItems: 4
>
> interrupt-names:
> minItems: 1
> @@ -77,6 +79,7 @@ properties:
> - const: dcvsh-irq-0
> - const: dcvsh-irq-1
> - const: dcvsh-irq-2
> + - const: dcvsh-irq-3
>
> '#freq-domain-cells':
> const: 1
>
> --
> 2.34.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: cpufreq: qcom-hw: add a 4th frequency domain
2023-08-21 7:39 ` [PATCH 1/2] dt-bindings: cpufreq: qcom-hw: add a 4th frequency domain Neil Armstrong
2023-08-23 8:07 ` Manivannan Sadhasivam
@ 2023-08-23 13:16 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2023-08-23 13:16 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rafael J. Wysocki, Viresh Kumar, Krzysztof Kozlowski,
Conor Dooley, Manivannan Sadhasivam, Andy Gross, Bjorn Andersson,
Konrad Dybcio, linux-pm, devicetree, linux-kernel, linux-arm-msm
On Mon, Aug 21, 2023 at 09:39:13AM +0200, Neil Armstrong wrote:
> On new platforms, a 4th frequency domain is used, document it.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> index a6b3bb8fdf33..c1d225fcf2d5 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> @@ -49,6 +49,7 @@ properties:
> - description: Frequency domain 0 register region
> - description: Frequency domain 1 register region
> - description: Frequency domain 2 register region
> + - description: Frequency domain 3 register region
>
> reg-names:
> minItems: 1
> @@ -56,6 +57,7 @@ properties:
> - const: freq-domain0
> - const: freq-domain1
> - const: freq-domain2
> + - const: freq-domain3
>
> clocks:
> items:
> @@ -69,7 +71,7 @@ properties:
>
> interrupts:
> minItems: 1
> - maxItems: 3
> + maxItems: 4
>
> interrupt-names:
> minItems: 1
> @@ -77,6 +79,7 @@ properties:
> - const: dcvsh-irq-0
> - const: dcvsh-irq-1
> - const: dcvsh-irq-2
> + - const: dcvsh-irq-3
Truly useless names with foo<index>...
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] cpufreq: qcom-cpufreq-hw: add support for 4 freq domains
2023-08-21 7:39 [PATCH 0/2] qcom-cpufreq-hw: add support for 4 freq domains Neil Armstrong
2023-08-21 7:39 ` [PATCH 1/2] dt-bindings: cpufreq: qcom-hw: add a 4th frequency domain Neil Armstrong
@ 2023-08-21 7:39 ` Neil Armstrong
2023-08-21 11:48 ` Konrad Dybcio
2023-08-23 15:01 ` [PATCH 0/2] " Viresh Kumar
2 siblings, 1 reply; 7+ messages in thread
From: Neil Armstrong @ 2023-08-21 7:39 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Manivannan Sadhasivam, Andy Gross, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, devicetree, linux-kernel, linux-arm-msm, Neil Armstrong
Add support for up to 4 frequency domains as used on new
platforms.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/cpufreq/qcom-cpufreq-hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
index f24cf2eddf1e..70b0f21968a0 100644
--- a/drivers/cpufreq/qcom-cpufreq-hw.c
+++ b/drivers/cpufreq/qcom-cpufreq-hw.c
@@ -28,7 +28,7 @@
#define GT_IRQ_STATUS BIT(2)
-#define MAX_FREQ_DOMAINS 3
+#define MAX_FREQ_DOMAINS 4
struct qcom_cpufreq_soc_data {
u32 reg_enable;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 2/2] cpufreq: qcom-cpufreq-hw: add support for 4 freq domains
2023-08-21 7:39 ` [PATCH 2/2] cpufreq: qcom-cpufreq-hw: add support for 4 freq domains Neil Armstrong
@ 2023-08-21 11:48 ` Konrad Dybcio
0 siblings, 0 replies; 7+ messages in thread
From: Konrad Dybcio @ 2023-08-21 11:48 UTC (permalink / raw)
To: Neil Armstrong, Rafael J. Wysocki, Viresh Kumar, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Andy Gross, Bjorn Andersson
Cc: linux-pm, devicetree, linux-kernel, linux-arm-msm
On 21.08.2023 09:39, Neil Armstrong wrote:
> Add support for up to 4 frequency domains as used on new
> platforms.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] qcom-cpufreq-hw: add support for 4 freq domains
2023-08-21 7:39 [PATCH 0/2] qcom-cpufreq-hw: add support for 4 freq domains Neil Armstrong
2023-08-21 7:39 ` [PATCH 1/2] dt-bindings: cpufreq: qcom-hw: add a 4th frequency domain Neil Armstrong
2023-08-21 7:39 ` [PATCH 2/2] cpufreq: qcom-cpufreq-hw: add support for 4 freq domains Neil Armstrong
@ 2023-08-23 15:01 ` Viresh Kumar
2 siblings, 0 replies; 7+ messages in thread
From: Viresh Kumar @ 2023-08-23 15:01 UTC (permalink / raw)
To: Neil Armstrong
Cc: Rafael J. Wysocki, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Manivannan Sadhasivam, Andy Gross, Bjorn Andersson, Konrad Dybcio,
linux-pm, devicetree, linux-kernel, linux-arm-msm
On 21-08-23, 09:39, Neil Armstrong wrote:
> New platforms can have up to to 4 frequency domains,
> Document and add support for this.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Neil Armstrong (2):
> dt-bindings: cpufreq: qcom-hw: add a 4th frequency domain
> cpufreq: qcom-cpufreq-hw: add support for 4 freq domains
>
> Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 5 ++++-
> drivers/cpufreq/qcom-cpufreq-hw.c | 2 +-
> 2 files changed, 5 insertions(+), 2 deletions(-)
> ---
> base-commit: 47d9bb711707d15b19fad18c8e2b4b027a264a3a
> change-id: 20230821-topic-sm8x50-upstream-cpufreq-4-domains-2ca50ff2cce2
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 7+ messages in thread