From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19CAE71D37 for ; Fri, 29 Sep 2023 13:48:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233266AbjI2Ns2 (ORCPT ); Fri, 29 Sep 2023 09:48:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233217AbjI2Ns1 (ORCPT ); Fri, 29 Sep 2023 09:48:27 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E8661A8 for ; Fri, 29 Sep 2023 06:48:25 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmDqb-0003x9-CW; Fri, 29 Sep 2023 15:48:01 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qmDqa-009pKl-AB; Fri, 29 Sep 2023 15:48:00 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qmDqa-005wF3-0o; Fri, 29 Sep 2023 15:48:00 +0200 Date: Fri, 29 Sep 2023 15:47:57 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: "Rafael J. Wysocki" Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, linux-acpi@vger.kernel.org, devel@acpica.org, linux-pm@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [rafael-pm:bleeding-edge 48/94] drivers/thermal/amlogic_thermal.c:303:16: error: void value not ignored as it ought to be Message-ID: <20230929134757.5ztol37eqttvr4wo@pengutronix.de> References: <202309291214.Hjn3gJ94-lkp@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h5m4qeuiyxuq2nm4" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --h5m4qeuiyxuq2nm4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 29, 2023 at 12:37:03PM +0200, Rafael J. Wysocki wrote: > On Fri, Sep 29, 2023 at 6:21=E2=80=AFAM kernel test robot = wrote: > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm= =2Egit bleeding-edge > > head: 2cff74feed4a2a3a1c220e0ee2838b85b08d4999 > > commit: 88af8b66ffedcad8c5a1522f6a9c02bf8129a951 [48/94] thermal: amlog= ic: Convert to platform remove callback returning void > > config: arm-randconfig-004-20230929 (https://download.01.org/0day-ci/ar= chive/20230929/202309291214.Hjn3gJ94-lkp@intel.com/config) > > compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0 > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/arc= hive/20230929/202309291214.Hjn3gJ94-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202309291214.Hjn3gJ94-l= kp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > drivers/thermal/amlogic_thermal.c: In function 'amlogic_thermal_susp= end': > > >> drivers/thermal/amlogic_thermal.c:303:16: error: void value not igno= red as it ought to be > > 303 | return amlogic_thermal_disable(data); > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > amlogic_thermal_disable() should not be modified by this commit - > fixed up in the tree. Thanks for choosing an option that hides that embarrassing build failure. :-) IMHO https://lore.kernel.org/all/20230929061305.2351953-1-u.kleine-koenig@pengut= ronix.de is the nicer fix because with that amlogic_thermal_remove() would ignore the return value of amlogic_thermal_disable(). On top of your current tree that would be: diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_th= ermal.c index 5877cde25b79..562f63b7bf27 100644 --- a/drivers/thermal/amlogic_thermal.c +++ b/drivers/thermal/amlogic_thermal.c @@ -167,13 +167,11 @@ static int amlogic_thermal_enable(struct amlogic_ther= mal *data) return 0; } =20 -static int amlogic_thermal_disable(struct amlogic_thermal *data) +static void amlogic_thermal_disable(struct amlogic_thermal *data) { regmap_update_bits(data->regmap, TSENSOR_CFG_REG1, TSENSOR_CFG_REG1_ENABLE, 0); clk_disable_unprepare(data->clk); - - return 0; } =20 static int amlogic_thermal_get_temp(struct thermal_zone_device *tz, int *t= emp) @@ -302,7 +300,9 @@ static int __maybe_unused amlogic_thermal_suspend(struc= t device *dev) { struct amlogic_thermal *data =3D dev_get_drvdata(dev); =20 - return amlogic_thermal_disable(data); + amlogic_thermal_disable(data); + + return 0; } =20 static int __maybe_unused amlogic_thermal_resume(struct device *dev) But I won't argue further and consider the case closed. Thanks Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=C3=B6nig = | Industrial Linux Solutions | https://www.pengutronix.de/ | --h5m4qeuiyxuq2nm4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmUW1YwACgkQj4D7WH0S /k5fBwf8DU6ytLGBe3UCbC4aCs+KSO9KKMjRB2/wRBIg/wcF8uSiGYXVEdxaqiTT OuDnFPRnlI0rxYff524ZBxgQCD8XFBR0qZYCs9Nd1aWYDfYNS3EDPxIJ7Zl1srjO OppgV0rQILZZ4I3+1WfxqaeQbdvQszrPIrdOS8gGdRvFkmxo/nMx9zrtDp7Xl0XO xeywc1J736A6+rSm7D56a7TzY/xwuqDT9f6IBqYskBCufGm3FEgbxjrV6hzXr4Bc 7MNU1kNZivh7TPMweQSUrmzoZRECWLA5I8w2Gt6GwTFgpNsEEce+26Cjq2qTipUI vzeYqecdnuRzTESFNswd4PClJC0biA== =oV9Q -----END PGP SIGNATURE----- --h5m4qeuiyxuq2nm4--