From: Conor Dooley <conor@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: daniel.lezcano@linaro.org, rafael@kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
conor+dt@kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH v3] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range min/maxItems
Date: Mon, 2 Oct 2023 13:27:11 +0100 [thread overview]
Message-ID: <20231002-unheard-copy-f9dceb6498a9@spud> (raw)
In-Reply-To: <20230928222130.580487-1-festevam@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1857 bytes --]
On Thu, Sep 28, 2023 at 07:21:30PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> The number of fsl,tmu-range entries vary among the several NXP SoCs.
>
> - lx2160a has two fsl,tmu-range entries (fsl,qoriq-tmu compatible)
> - imx8mq has four fsl,tmu-range entries. (fsl,imx8mq-tmu compatible)
> - imx93 has seven fsl,tmu-range entries. (fsl,qoriq-tmu compatible)
>
> Change minItems and maxItems accordingly.
>
> This fixes the following schema warning:
>
> imx93-11x11-evk.dtb: tmu@44482000: fsl,tmu-range: 'oneOf' conditional failed, one must be fixed:
> [2147483866, 2147483881, 2147483906, 2147483946, 2147484006, 2147484071, 2147484086] is too long
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
tbh, this seems like a situation where per compatible constraints should
be added, since each of the devices listed above has different
requirements.
Thanks,
Conor.
> ---
> Changes since v1:
> - Adjust min/maxItems to cover all NXP SoCs.
>
> Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
> index ee4780f186f9..60b9d79e7543 100644
> --- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
> @@ -36,7 +36,8 @@ properties:
> description: |
> The values to be programmed into TTRnCR, as specified by the SoC
> reference manual. The first cell is TTR0CR, the second is TTR1CR, etc.
> - minItems: 4
> + minItems: 2
> + maxItems: 7
>
> fsl,tmu-calibration:
> $ref: /schemas/types.yaml#/definitions/uint32-matrix
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-10-02 12:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 22:21 [PATCH v3] dt-bindings: thermal: qoriq-thermal: Adjust fsl,tmu-range min/maxItems Fabio Estevam
2023-10-02 12:27 ` Conor Dooley [this message]
2023-12-09 19:22 ` Fabio Estevam
2023-12-09 20:23 ` Conor Dooley
2023-12-09 20:59 ` Fabio Estevam
2023-12-10 14:52 ` Conor Dooley
2023-12-10 15:37 ` Rob Herring
2023-12-14 17:13 ` Conor Dooley
2024-01-03 21:39 ` Rob Herring
2024-01-03 21:51 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231002-unheard-copy-f9dceb6498a9@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).