From: Tony Lindgren <tony@atomide.com>
To: Thomas Richard <thomas.richard@bootlin.com>
Cc: linux-pm@vger.kernel.org, linux-serial@vger.kernel.org,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Kumar Udit <u-kumar1@ti.com>, Dhruva Gole <d-gole@ti.com>,
Kevin Hilman <khilman@baylibre.com>, Vignesh R <vigneshr@ti.com>
Subject: Re: serial: 8250_omap: suspend issue with console_suspend disabled
Date: Tue, 10 Oct 2023 09:51:45 +0300 [thread overview]
Message-ID: <20231010065145.GD27774@atomide.com> (raw)
In-Reply-To: <a5bee830-07af-426b-94ac-3574cba34bec@bootlin.com>
Hi,
* Thomas Richard <thomas.richard@bootlin.com> [231009 15:13]:
> > The runtime PM usage count should keep the related power domain on though,
> > sounds like this issue somewhere else if the power domains get force
> > suspended with runtime PM usage count?
>
> If I understand correctly, there are 2 solutions to keep the power
> domain on through.
> The first one is to set the flag GENPD_FLAG_ALWAYS_ON for the power domain.
> The second one is to set the wakup_path of the device (using
> device_set_wakeup_path) and set the flag GENPD_FLAG_ACTIVE_WAKEUP to the
> power domain.
>
> I didn't found any flag or option to say that the device is not
> suspended, but it is not an error, so we don't want to poweroff the
> power domain.
If no_console_suspend is set then GENPD_FLAG_ALWAYS_ON makes sense to
me as we want to see the debug messages. This will also alter the SoCs
suspend state though, so no_console_suspend is of limited use. Can you
please send an updated patch against tty-next branch for this?
It would be good to understand why the related power domain gets suspended
with active runtime PM usage count though. To me it seems this might be
an issue somewhere in the SoC related power domain code that just tries
to force suspend everything.
Regards,
Tony
next prev parent reply other threads:[~2023-10-10 6:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 9:56 serial: 8250_omap: suspend issue with console_suspend disabled Thomas Richard
2023-09-20 4:59 ` Kumar, Udit
2023-09-20 5:38 ` Tony Lindgren
2023-09-21 7:58 ` Thomas Richard
2023-09-25 13:03 ` Thomas Richard
2023-09-25 15:26 ` Tony Lindgren
2023-09-26 6:14 ` Tony Lindgren
2023-10-09 15:13 ` Thomas Richard
2023-10-10 6:51 ` Tony Lindgren [this message]
2023-10-10 9:37 ` Thomas Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010065145.GD27774@atomide.com \
--to=tony@atomide.com \
--cc=d-gole@ti.com \
--cc=gregory.clement@bootlin.com \
--cc=khilman@baylibre.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=thomas.richard@bootlin.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).