From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B82CD68F4 for ; Tue, 10 Oct 2023 06:51:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442330AbjJJGvv (ORCPT ); Tue, 10 Oct 2023 02:51:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442295AbjJJGvu (ORCPT ); Tue, 10 Oct 2023 02:51:50 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5A6B59D; Mon, 9 Oct 2023 23:51:47 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 0AB8980A9; Tue, 10 Oct 2023 06:51:47 +0000 (UTC) Date: Tue, 10 Oct 2023 09:51:45 +0300 From: Tony Lindgren To: Thomas Richard Cc: linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, Gregory CLEMENT , Kumar Udit , Dhruva Gole , Kevin Hilman , Vignesh R Subject: Re: serial: 8250_omap: suspend issue with console_suspend disabled Message-ID: <20231010065145.GD27774@atomide.com> References: <59b13c93-6637-3050-c145-31be0d6c12c9@bootlin.com> <20230920053828.GD5282@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi, * Thomas Richard [231009 15:13]: > > The runtime PM usage count should keep the related power domain on though, > > sounds like this issue somewhere else if the power domains get force > > suspended with runtime PM usage count? > > If I understand correctly, there are 2 solutions to keep the power > domain on through. > The first one is to set the flag GENPD_FLAG_ALWAYS_ON for the power domain. > The second one is to set the wakup_path of the device (using > device_set_wakeup_path) and set the flag GENPD_FLAG_ACTIVE_WAKEUP to the > power domain. > > I didn't found any flag or option to say that the device is not > suspended, but it is not an error, so we don't want to poweroff the > power domain. If no_console_suspend is set then GENPD_FLAG_ALWAYS_ON makes sense to me as we want to see the debug messages. This will also alter the SoCs suspend state though, so no_console_suspend is of limited use. Can you please send an updated patch against tty-next branch for this? It would be good to understand why the related power domain gets suspended with active runtime PM usage count though. To me it seems this might be an issue somewhere in the SoC related power domain code that just tries to force suspend everything. Regards, Tony