From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36BD7CD80A1 for ; Tue, 10 Oct 2023 10:30:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230516AbjJJKay (ORCPT ); Tue, 10 Oct 2023 06:30:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbjJJKax (ORCPT ); Tue, 10 Oct 2023 06:30:53 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F927C4; Tue, 10 Oct 2023 03:30:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j0tKrd13x+vWl+pYbS4/PK06TRwyo2NxnIpkIOOXqKc=; b=htxhTZCGyOZ3etFbWskmZIJtSe Tq78kImhii3bptFi4H2I9Mq1kRQDKLMRl5CJtKaJBVS/QZidbgjBAiAJbdq5TkUkfmjtLiI6BKyKH 5zmvplUiNziEZO7CRYqcoFctqGhx1AqwIhlU50MQ7p2McHXQuVpDcyqRTcoX4b4Lng8+pIZzQIxAm XlEIU6y8bxZnNbpKDtv3MmpxyUNxX+41l/gVSNoQho0c6ntF7gbRtM2vXbQDXZ0lQWXR94LyZ8w8K C5uI2EDzp7p58FGKy7KeRzoiWHBPk658vEkqVrd7HZ5e217TVzUQskX5ti05z/yXsa1DtigbmPLA9 ymBrmKlA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qqA0S-00GmiM-19; Tue, 10 Oct 2023 10:30:30 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 77582300392; Tue, 10 Oct 2023 12:30:29 +0200 (CEST) Date: Tue, 10 Oct 2023 12:30:29 +0200 From: Peter Zijlstra To: Meng Li Cc: "Rafael J . Wysocki" , Huang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-acpi@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Nathan Fontenot , Deepak Sharma , Alex Deucher , Mario Limonciello , Shimmer Huang , Perry Yuan , Xiaojian Du , Viresh Kumar , Borislav Petkov Subject: Re: [PATCH V8 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion. Message-ID: <20231010103029.GH377@noisy.programming.kicks-ass.net> References: <20231009024932.2563622-1-li.meng@amd.com> <20231009024932.2563622-2-li.meng@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231009024932.2563622-2-li.meng@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Oct 09, 2023 at 10:49:26AM +0800, Meng Li wrote: > amd-pstate driver also uses SCHED_MC_PRIO, so decouple the requirement > of CPU_SUP_INTEL from the dependencies to allow compilation in kernels > without Intel CPU support. > > Reviewed-by: Mario Limonciello > Reviewed-by: Huang Rui > Signed-off-by: Meng Li > --- > arch/x86/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 66bfabae8814..a2e163acf623 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -1054,8 +1054,9 @@ config SCHED_MC > > config SCHED_MC_PRIO > bool "CPU core priorities scheduler support" > - depends on SCHED_MC && CPU_SUP_INTEL > - select X86_INTEL_PSTATE > + depends on SCHED_MC > + select X86_INTEL_PSTATE if CPU_SUP_INTEL > + select X86_AMD_PSTATE if CPU_SUP_AMD && ACPI > select CPU_FREQ > default y > help The pedantic side of me wants to point out that: depends on SCHED_MC depends on CPU_SUP_INTEL || CPU_SUP_AMD would be more accurate, as we still have a pile of other SUPs. Anyway, no real objection, distros will have them all set anyway.