From: Viresh Kumar <viresh.kumar@linaro.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: linux-kernel@vger.kernel.org, mmayer@broadcom.com,
"Rafael J. Wysocki" <rafael@kernel.org>,
"open list:CPU FREQUENCY SCALING FRAMEWORK"
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: ARM_BRCMSTB_AVS_CPUFREQ cannot be used with ARM_SCMI_CPUFREQ
Date: Wed, 11 Oct 2023 10:52:57 +0530 [thread overview]
Message-ID: <20231011052257.ly5g5zm5quqpcgfb@vireshk-i7> (raw)
In-Reply-To: <20231010181626.3449090-1-florian.fainelli@broadcom.com>
On 10-10-23, 11:16, Florian Fainelli wrote:
> The brcmstb-avs-cpufreq driver is considered a legacy driver and since
> 2018, ARCH_BRCMSTB systems have been using scmi-cpufreq. As a matter of
> fact, when SCMI is in use, brcmstb-avs-cpufreq is unusable since the
> SCMI firmware takes over, this can result in various problems, including
> external synchronous aborts.
>
> Express those constraints such that the driver is not enabled by default
> when SCMI CPU frequency scaling is in use.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
> drivers/cpufreq/Kconfig.arm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
> index 123b4bbfcfee..c287305820b7 100644
> --- a/drivers/cpufreq/Kconfig.arm
> +++ b/drivers/cpufreq/Kconfig.arm
> @@ -90,7 +90,7 @@ config ARM_VEXPRESS_SPC_CPUFREQ
>
> config ARM_BRCMSTB_AVS_CPUFREQ
> tristate "Broadcom STB AVS CPUfreq driver"
> - depends on ARCH_BRCMSTB || COMPILE_TEST
> + depends on ARCH_BRCMSTB && !(ARM_SCMI_PROTOCOL && ARM_SCMI_CPUFREQ) || COMPILE_TEST
ARM_SCMI_CPUFREQ already implies ARM_SCMI_PROTOCOL, you don't need to
add both here.
--
viresh
prev parent reply other threads:[~2023-10-11 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 18:16 [PATCH] cpufreq: ARM_BRCMSTB_AVS_CPUFREQ cannot be used with ARM_SCMI_CPUFREQ Florian Fainelli
2023-10-11 5:22 ` Viresh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231011052257.ly5g5zm5quqpcgfb@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=florian.fainelli@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mmayer@broadcom.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox