From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31BA8C001DF for ; Sun, 22 Oct 2023 17:39:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232617AbjJVRjV (ORCPT ); Sun, 22 Oct 2023 13:39:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbjJVRjU (ORCPT ); Sun, 22 Oct 2023 13:39:20 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D97BBF2; Sun, 22 Oct 2023 10:39:18 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B49A0C433C8; Sun, 22 Oct 2023 17:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697996358; bh=V2tHPMR1TOkzDOcp6KPYSszP9A29fq1AuLXpL5Br5NM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K6/4L4H7VtSF3BDW3Lq6DK9X1E8D3f58bD2SDrSbnNAGYVFktdLMflOBllDGlYWoC GIiHZIuL8+AfxBwjT+JTZAcPcjA7TfMFEXeaYSIy6H3i1EL3MuuGrmPLGMaGXtxcHn L2iTgbKxkiU3ufeX30VLqh1pcCWhMw6pOfvLwAQVPrLbiKRtXnh2YKFqBPsRoQrsIn YSm2UF9eJISTXVDKPKU1q5Hy1i52Ze9JT3TX3KAHhujFayx9ME/oYAVZG+q38n0Vvl lx6oMuZ6+zcugE2dq0PNpBkH6Pdv/ODEzfnZR0bMMrkk9V2ID3hKA6Z3Jxy3DTSf23 TR7830cTppCgA== Date: Sun, 22 Oct 2023 18:39:12 +0100 From: Conor Dooley To: Alexander Stein Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Ulf Hansson , Marek Vasut , Pengutronix Kernel Team , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/5] dt-bindings: soc: imx93-media-blk-ctrl: Add LDB subnode into schema and example Message-ID: <20231022-helper-dating-a0f65a8f6f72@spud> References: <20231020130019.665853-1-alexander.stein@ew.tq-group.com> <20231020130019.665853-3-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OjkkNCobwn9OU9NU" Content-Disposition: inline In-Reply-To: <20231020130019.665853-3-alexander.stein@ew.tq-group.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --OjkkNCobwn9OU9NU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Yo, On Fri, Oct 20, 2023 at 03:00:15PM +0200, Alexander Stein wrote: > Document the LDB bridge subnode and add the subnode into the example. > For the subnode to work, the block control must scan its subnodes and > bind drivers to them, do not misuse either simple-bus or simple-mfd > here. >=20 > Signed-off-by: Alexander Stein > --- > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-bl= k-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk= -ctrl.yaml > index b3554e7f9e76..5ba66dfb0e05 100644 > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.= yaml > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctrl.= yaml > @@ -24,6 +24,12 @@ properties: > reg: > maxItems: 1 > =20 > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 1 > + > '#power-domain-cells': > const: 1 > =20 > @@ -46,9 +52,16 @@ properties: > - const: csi > - const: dsi > =20 > + bridge@20: > + type: object > + $ref: /schemas/display/bridge/fsl,ldb.yaml# > + unevaluatedProperties: false > + > required: > - compatible > - reg > + - '#address-cells' > + - '#size-cells' It seems to make little sense to me that these would become required when the bridge is optional. Is it valid to have one of these media-blk-ctrls without the ldb subnode? > - power-domains > - clocks > - clock-names > @@ -77,4 +90,35 @@ examples: > clock-names =3D "apb", "axi", "nic", "disp", "cam", > "pxp", "lcdif", "isi", "csi", "dsi"; > #power-domain-cells =3D <1>; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + > + bridge@20 { > + compatible =3D "fsl,imx93-ldb"; > + reg =3D <0x20 0x4>, <0x24 0x4>; > + reg-names =3D "ldb", "lvds"; > + clocks =3D <&clk IMX93_CLK_LVDS_GATE>; > + clock-names =3D "ldb"; > + > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@0 { > + reg =3D <0>; > + > + ldb_from_lcdif2: endpoint { > + remote-endpoint =3D <&lcdif2_to_ldb>; > + }; > + }; > + > + port@1 { > + reg =3D <1>; > + > + ldb_lvds: endpoint { > + remote-endpoint =3D <&ldb_to_panel>; > + }; > + }; > + }; > + }; > }; > --=20 > 2.34.1 >=20 --OjkkNCobwn9OU9NU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZTVeQAAKCRB4tDGHoIJi 0l9qAP0VlEaAluBRXsbW8N9Eandg3TOavmfUjpyH+1wBFkQQOwEA0yPLz0di2m0x pDXwKnhPdmOAymwdxMVUVzBgnfeRrgs= =7x7o -----END PGP SIGNATURE----- --OjkkNCobwn9OU9NU--