Re: [PATCH v5 8/9] thermal: exynos: use BIT wherever possible

Lukasz Luba
2023-11-20T15:23:56Z

Hi Mateusz,

On 11/20/23 14:50, Mateusz Majewski wrote:
> The original driver did not use that macro and it allows us to make our
> intentions slightly clearer.
>
> Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>

[snip]

> @@ -590,15 +590,15 @@ static void exynos5433_tmu_control(struct platform_device *pdev, bool on)
> continue;
>
> interrupt_en |=
> - (1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i));
> + BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i);
> }
>
> interrupt_en |=
> interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;
>
> - con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT);
> + con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);
> } else

Minor issue: the if-else segment here. When the 'if' has the
brackets, then the 'else' should have them as well,
even if there is only a single line under 'else'.
It's not strictly to this patch, but you can address that
later somewhere (just saw it here).

> - con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT);
> + con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT);
>
> pd_det_en = on ? EXYNOS5433_PD_DET_EN : 0;
>
> @@ -622,17 +622,17 @@ static void exynos7_tmu_control(struct platform_device *pdev, bool on)
> continue;
>
> interrupt_en |=
> - (1 << (EXYNOS7_TMU_INTEN_RISE0_SHIFT + i));
> + BIT(EXYNOS7_TMU_INTEN_RISE0_SHIFT + i);
> }
>
> interrupt_en |=
> interrupt_en << EXYNOS_TMU_INTEN_FALL0_SHIFT;
>
> - con |= (1 << EXYNOS_TMU_CORE_EN_SHIFT);
> - con |= (1 << EXYNOS7_PD_DET_EN_SHIFT);
> + con |= BIT(EXYNOS_TMU_CORE_EN_SHIFT);
> + con |= BIT(EXYNOS7_PD_DET_EN_SHIFT);
> } else {
> - con &= ~(1 << EXYNOS_TMU_CORE_EN_SHIFT);
> - con &= ~(1 << EXYNOS7_PD_DET_EN_SHIFT);
> + con &= ~BIT(EXYNOS_TMU_CORE_EN_SHIFT);
> + con &= ~BIT(EXYNOS7_PD_DET_EN_SHIFT);
> }
>
> writel(interrupt_en, data->base + EXYNOS7_TMU_REG_INTEN);

The patch LGTM,

Reviewed-by Lukasz Luba <lukasz.luba@arm.com>

Regards,
Lukasz