linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Chris Feng <chris.feng@mediatek.com>,
	rafael@kernel.org, pavel@ucw.cz, len.brown@intel.com
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@kernel.org, hua.yang@mediatek.com, ting.wang@mediatek.com,
	liang.lu@mediatek.com, chetan.kumar@mediatek.com,
	Chris Feng <chris.feng@mediatek.com>
Subject: Re: [PATCH v2] PM: hibernate: Fix the bug where wake events cannot wake system during hibernation
Date: Mon, 20 Nov 2023 22:55:16 +0800	[thread overview]
Message-ID: <202311202258.eqaMpEXc-lkp@intel.com> (raw)
In-Reply-To: <20231120081516.55172-1-chris.feng@mediatek.com>

Hi Chris,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.7-rc2 next-20231120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chris-Feng/PM-hibernate-Fix-the-bug-where-wake-events-cannot-wake-system-during-hibernation/20231120-161752
base:   linus/master
patch link:    https://lore.kernel.org/r/20231120081516.55172-1-chris.feng%40mediatek.com
patch subject: [PATCH v2] PM: hibernate: Fix the bug where wake events cannot wake system during hibernation
config: arm-randconfig-003-20231120 (https://download.01.org/0day-ci/archive/20231120/202311202258.eqaMpEXc-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231120/202311202258.eqaMpEXc-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311202258.eqaMpEXc-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/power/hibernate.c:672:4: error: call to undeclared function 'swsusp_unmark'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                           swsusp_unmark();
                           ^
   1 error generated.


vim +/swsusp_unmark +672 kernel/power/hibernate.c

   664	
   665		switch (hibernation_mode) {
   666		case HIBERNATION_REBOOT:
   667			kernel_restart(NULL);
   668			break;
   669		case HIBERNATION_PLATFORM:
   670			error = hibernation_platform_enter();
   671			if (error == -EAGAIN || error == -EBUSY) {
 > 672				swsusp_unmark();
   673				events_check_enabled = false;
   674				pr_err("Hibernation Abort.\n");
   675				return;
   676			}
   677			fallthrough;
   678		case HIBERNATION_SHUTDOWN:
   679			if (kernel_can_power_off())
   680				kernel_power_off();
   681			break;
   682		}
   683		kernel_halt();
   684		/*
   685		 * Valid image is on the disk, if we continue we risk serious data
   686		 * corruption after resume.
   687		 */
   688		pr_crit("Power down manually\n");
   689		while (1)
   690			cpu_relax();
   691	}
   692	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      parent reply	other threads:[~2023-11-20 15:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20  8:15 [PATCH v2] PM: hibernate: Fix the bug where wake events cannot wake system during hibernation Chris Feng
2023-11-20 12:33 ` Rafael J. Wysocki
2023-11-20 14:55 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202311202258.eqaMpEXc-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=chetan.kumar@mediatek.com \
    --cc=chris.feng@mediatek.com \
    --cc=hua.yang@mediatek.com \
    --cc=len.brown@intel.com \
    --cc=liang.lu@mediatek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=stable@kernel.org \
    --cc=ting.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).