From: Peter Zijlstra <peterz@infradead.org>
To: "Aiqun(Maria) Yu" <quic_aiquny@quicinc.com>
Cc: Elliot Berman <quic_eberman@quicinc.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Pavel Machek <pavel@ucw.cz>, Ingo Molnar <mingo@kernel.org>,
linux-arm-msm@vger.kernel.org,
Pavan Kondeti <quic_pkondeti@quicinc.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Abhijeet Dharmapurikar <quic_adharmap@quicinc.com>
Subject: Re: [PATCH 0/2] freezer,sched: do not restore saved_state of a thawed task
Date: Tue, 28 Nov 2023 18:31:19 +0100 [thread overview]
Message-ID: <20231128173119.GC3818@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <a86228f5-c1ae-4afe-87bd-5144633a9601@quicinc.com>
On Tue, Nov 28, 2023 at 05:12:00PM +0800, Aiqun(Maria) Yu wrote:
> On 11/21/2023 1:36 AM, Elliot Berman wrote:
> > This series applies couple fixes to commit 8f0eed4a78a8 ("freezer,sched:
> > Use saved_state to reduce some spurious wakeups") which was found while
> > testing with legacy cgroup freezer. My original testing was only with
> > system-wide freezer. We found that thaw_task could be called on a task
> > which was already frozen. Prior to commit 8f0eed4a78a8 ("freezer,sched:
> > Use saved_state to reduce some spurious wakeups"), this wasn't an issue
> > as kernel would try to wake up TASK_FROZEN, which wouldn't match the
> > thawed task state, and no harm done to task. After commit 8f0eed4a78a8
> > ("freezer,sched: Use saved_state to reduce some spurious wakeups"), it
> > was possible to overwrite the state of thawed task.
> >
> > To: Rafael J. Wysocki <rafael@kernel.org>
> > To: Pavel Machek <pavel@ucw.cz>
> > To: Ingo Molnar <mingo@kernel.org>
> > To: Peter Zijlstra (Intel) <peterz@infradead.org>
> > Cc: <linux-arm-msm@vger.kernel.org>
> > Cc: Pavan Kondeti <quic_pkondeti@quicinc.com>
> > Cc: Aiqun Yu (Maria) <quic_aiquny@quicinc.com>
> > Cc: <linux-pm@vger.kernel.org>
> > Cc: <linux-kernel@vger.kernel.org>
> > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> Shall we add Fixed tag and Cc: stable@vger.kernel.org ?
> Since it is fixing a stable user thread hung issue.
If you want this routed through urgent, then yes.
next prev parent reply other threads:[~2023-11-28 17:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 17:36 [PATCH 0/2] freezer,sched: do not restore saved_state of a thawed task Elliot Berman
2023-11-20 17:36 ` [PATCH 1/2] " Elliot Berman
2023-11-20 17:36 ` [PATCH 2/2] freezer,sched: clean saved_state when restoring it during thaw Elliot Berman
2023-11-28 9:12 ` [PATCH 0/2] freezer,sched: do not restore saved_state of a thawed task Aiqun(Maria) Yu
2023-11-28 17:31 ` Peter Zijlstra [this message]
2023-11-28 17:33 ` Elliot Berman
2023-11-28 17:54 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128173119.GC3818@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pavel@ucw.cz \
--cc=quic_adharmap@quicinc.com \
--cc=quic_aiquny@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_pkondeti@quicinc.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox